ant-design-mobile icon indicating copy to clipboard operation
ant-design-mobile copied to clipboard

feat(swiper): support RTL mode

Open RaHsu opened this issue 1 year ago • 7 comments

ref: #6446 Swiper components support RTL

RaHsu avatar Nov 23 '23 08:11 RaHsu

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6450.surge.sh

github-actions[bot] avatar Nov 23 '23 08:11 github-actions[bot]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (671ea15) 92.10% compared to head (d5f0b6b) 92.25%. Report is 15 commits behind head on master.

:exclamation: Current head d5f0b6b differs from pull request most recent head 7fa199d. Consider uploading reports for the commit 7fa199d to get more accurate results

Files Patch % Lines
src/components/swiper/swiper.tsx 88.00% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6450      +/-   ##
==========================================
+ Coverage   92.10%   92.25%   +0.15%     
==========================================
  Files         316      316              
  Lines        6861     6883      +22     
  Branches     1719     1743      +24     
==========================================
+ Hits         6319     6350      +31     
+ Misses        504      497       -7     
+ Partials       38       36       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 23 '23 08:11 codecov[bot]

@1587315093 修改过了,麻烦再review一下哇

RaHsu avatar Dec 07 '23 08:12 RaHsu

@zombieJ 麻烦看一下呢,这个提交已经pending一个月了

RaHsu avatar Dec 21 '23 07:12 RaHsu

大佬们,什么时候合并一下这个需求,正好有阿拉伯语地区的适配需求,目前只能写死覆盖好几处direction: rtl;

asd116725 avatar May 27 '24 02:05 asd116725

大佬们,什么时候合并一下这个需求,正好有阿拉伯语地区的适配需求,目前只能写死覆盖好几处direction: rtl;

@zombieJ +1

cbbfcd avatar Jun 05 '24 03:06 cbbfcd

@asd116725 @cbbfcd 这个 PR 代码冲突了,需要 @RaHsu 解决一下先。

afc163 avatar Jun 05 '24 03:06 afc163