ant-design-icons icon indicating copy to clipboard operation
ant-design-icons copied to clipboard

CSP: Remove @babel/runtime from dependencies

Open deleonio opened this issue 2 years ago • 7 comments

@babel/runtime contains a dependency regenenerator-runtime. And this break the Content-Security-Policy unsafe-eval.

I think, that @babel/runtime should not be a part of dependency. It must be a part of devDependency?!

deleonio avatar Jul 13 '21 03:07 deleonio

Read that: @tellnes

No issue tab?! - https://github.com/ant-design/react-slick

deleonio avatar Jul 13 '21 03:07 deleonio

Read that: @tellnes

No issue tab?! - https://github.com/ant-design/react-slick

?

tellnes avatar Jul 13 '21 09:07 tellnes

@tellnes : at the repo - there is no active isssue tab. Please logout and try it.

We have CSP errors and we should remove the unsafe-eval.

deleonio avatar Jul 16 '21 03:07 deleonio

Yes, but why do you mention me? I'm not a maintainer, just a random contributor sending the latest PR that got merged to @ant-design/react-slick.

tellnes avatar Jul 16 '21 09:07 tellnes

Fix it with your bundler: https://leanupjs.org/1.2/guide/migration/#if-you-have-unsafe-eval-with-babel-runtime

deleonio avatar Jul 17 '21 09:07 deleonio

@yoyo837 - Please check this issue.

deleonio avatar Jul 17 '21 09:07 deleonio

Hi! This issue can probably be closed; @babel/[email protected] does not depend on regenerator-runtime anymore.

nicolo-ribaudo avatar May 22 '22 08:05 nicolo-ribaudo