ant-design-icons icon indicating copy to clipboard operation
ant-design-icons copied to clipboard

Support React 17

Open plotka opened this issue 3 years ago • 3 comments

Add support for React >=17 as a peer dependency

plotka avatar Feb 11 '21 16:02 plotka

This should already be solved: https://github.com/ant-design/ant-design-icons/issues/394

fgblomqvist avatar Mar 18 '21 17:03 fgblomqvist

Not in icons:

npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   dev react@"^17.0.2" from the root project
npm ERR!   peer react@">=16.0.0" from @ant-design/[email protected]
npm ERR!   node_modules/@ant-design/icons
npm ERR!     @ant-design/icons@"^4.6.2" from [email protected]
npm ERR!     node_modules/antd
npm ERR!       dev antd@"^4.15.1" from the root project

IronSean avatar Apr 14 '21 21:04 IronSean

I'm sorry if this issue should be considered closed, but I don't think I fully understand peer dependencies. I thought a change was made to support React >= 17 but I still get this error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"17.0.1" from the root project
npm ERR!   peer react@">=16.0.0" from @ant-design/[email protected]
npm ERR!   node_modules/@ant-design/icons
npm ERR!     @ant-design/icons@"^4.7.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"17.0.2" from [email protected]
npm ERR! node_modules/react-dom
npm ERR!   peer react-dom@">=16.0.0" from @ant-design/[email protected]
npm ERR!   node_modules/@ant-design/icons
npm ERR!     @ant-design/icons@"^4.7.0" from the root project

garviand avatar Jan 28 '22 17:01 garviand