pymapdl icon indicating copy to clipboard operation
pymapdl copied to clipboard

fix(cli): check access process on windows

Open SMoraisAnsys opened this issue 1 month ago • 2 comments

Description

When running on windows, the process username() can contain the DOMAIN which makes the comparison fail.

Issue linked

None

Checklist

SMoraisAnsys avatar Nov 06 '25 14:11 SMoraisAnsys

Codecov Report

:x: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review. :white_check_mark: Project coverage is 91.34%. Comparing base (be80897) to head (9a30857). :warning: Report is 3 commits behind head on main.

:x: Your patch status has failed because the patch coverage (66.66%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4293      +/-   ##
==========================================
+ Coverage   91.28%   91.34%   +0.06%     
==========================================
  Files         193      193              
  Lines       15742    15745       +3     
==========================================
+ Hits        14370    14383      +13     
+ Misses       1372     1362      -10     
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 06 '25 15:11 codecov[bot]

@germa89 The current implementation of the tests do not allow me to test without having mapdl installed (or that's my understand from the need to provide a path for ansysxxx). Would you like me to update the current test so that it patches a few pymapdl commands and runs without requiring any local install ?

SMoraisAnsys avatar Nov 07 '25 16:11 SMoraisAnsys