vscode-ansible icon indicating copy to clipboard operation
vscode-ansible copied to clipboard

Probably wrong reference to `ansible.ansible.path` variable

Open ChristianCiach opened this issue 1 year ago • 1 comments

Sanity check

  • [X] I certify that the redhat.ansible extension is in use and the language of the document in this bug report shows up as Ansible

Summary

I noticed that the command Ansible playbook: Run playbook via 'ansible-playbook' always tries to use /usr/bin/ansible-playbook, no matter what I configured in the settings.

I am not a TypeScript developer, so I have a hard time making sense of the source code of this extension, but I think this is the culprit:

vscode.workspace.getConfiguration("ansible.ansible.path").path

I think this should actually be..

vscode.workspace.getConfiguration("ansible.ansible").path

This would be consistent with this piece of code, which seems to work fine:

vscode.workspace.getConfiguration("ansible.ansibleNavigator").path

Extension version

v0.13.60

VS Code version

1.71.0

Ansible Version

ansible [core 2.13.2]
  config file = None
  configured module search path = ['/home/christianc/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /data/ssd/christianc/emsconda/envs/core-platform-ng/lib/python3.9/site-packages/ansible
  ansible collection location = /home/christianc/.ansible/collections:/usr/share/ansible/collections
  executable location = /data/ssd/christianc/emsconda/envs/core-platform-ng/bin/ansible
  python version = 3.9.13 | emsys distribution | (main, Aug 31 2022, 15:33:17) [GCC 11.2.1 20220127 (Red Hat 11.2.1-9)]
  jinja version = 3.1.2
  libyaml = True

OS / Environment

Fedora 36 with custom conda-based pyhon environment

Relevant log output

No response

ChristianCiach avatar Sep 06 '22 20:09 ChristianCiach

Reference to the line that I am talking about:

https://github.com/ansible/vscode-ansible/blob/e469afd0474b778bb0c2e5cdff1329f1717654e4/src/features/runner.ts#L81

ChristianCiach avatar Sep 06 '22 20:09 ChristianCiach

Why was this closed? Still looks exactly the same in current main branch.

ChristianCiach avatar Feb 07 '23 13:02 ChristianCiach