vscode-ansible icon indicating copy to clipboard operation
vscode-ansible copied to clipboard

Improve e2e test timings

Open priyamsahoo opened this issue 2 years ago • 2 comments

This PR:

  • decreases sleep timing between diagnostic tests.
  • decreases sleep timing during re-initialization of the server.

priyamsahoo avatar Jul 26 '22 05:07 priyamsahoo

@ssbarnea, I would suggest keeping the issue open, but for the time being, we can merge this change as this PR improves the test timings significantly, both, in local jobs and the CI jobs.

We can look at the real issue when we are free with the works with the work that we are currently doing. It is not blocking anything currently.

priyamsahoo avatar Aug 25 '22 02:08 priyamsahoo

@ssbarnea, I would suggest keeping the issue open, but for the time being, we can merge this change as this PR improves the test timings significantly, both, in local jobs and the CI jobs.

We can look at the real issue when we are free with the works with the work that we are currently doing. It is not blocking anything currently.

Yep. Approved and activated auto-merge. If it happens to pass, it will get merged, if not, probably is a sign that reducing might not be best idea. Our machines are always faster than GHA, so we should be fine.

ssbarnea avatar Aug 25 '22 08:08 ssbarnea