BugFix - awx_collection - lookup_organization failed when teams and resources are not in the same org
SUMMARY
When using "role" module with "lookup_organization", it fails to find the teams it is trying to assign the roles to.
It is because the "lookup_data_populated" is not resetting, so it looks up the teams in the "lookup_organization" for the resources. Mostly it is missing "key == 'teams'" condition.
The integration test didn't catch it because it is not trying to assign role across different organizations.
ISSUE TYPE
- Bugfix for awx_collection
COMPONENT NAME
awx_collection/plugins/modules/role.py
AWX VERSION
ADDITIONAL INFORMATION
@ecchong are you still working on this? Do you need any help?
@pb82 it is ready for review
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Hi, @pb82 What else do we need to move it forward?
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 75.26%. Comparing base (
0f0f5aa) to head (32ce05f). Report is 62 commits behind head on devel.
:white_check_mark: All tests successful. No failed tests found.
:rocket: New features to boost your workflow:
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.