awx icon indicating copy to clipboard operation
awx copied to clipboard

BugFix - awx_collection - lookup_organization failed when teams and resources are not in the same org

Open ecchong opened this issue 1 year ago • 1 comments

SUMMARY

When using "role" module with "lookup_organization", it fails to find the teams it is trying to assign the roles to.

It is because the "lookup_data_populated" is not resetting, so it looks up the teams in the "lookup_organization" for the resources. Mostly it is missing "key == 'teams'" condition.

The integration test didn't catch it because it is not trying to assign role across different organizations.

ISSUE TYPE
  • Bugfix for awx_collection
COMPONENT NAME

awx_collection/plugins/modules/role.py

AWX VERSION

ADDITIONAL INFORMATION

ecchong avatar Oct 11 '24 16:10 ecchong

@ecchong are you still working on this? Do you need any help?

pb82 avatar Oct 22 '24 11:10 pb82

@pb82 it is ready for review

ecchong avatar Oct 22 '24 12:10 ecchong

Hi, @pb82 What else do we need to move it forward?

ecchong avatar Jan 16 '25 17:01 ecchong

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.26%. Comparing base (0f0f5aa) to head (32ce05f). Report is 62 commits behind head on devel.

:white_check_mark: All tests successful. No failed tests found.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 12 '25 15:03 codecov[bot]