awx icon indicating copy to clipboard operation
awx copied to clipboard

Implement an option to choose a job type on relaunch (issue #14177)

Open Sasa993 opened this issue 1 year ago • 6 comments

SUMMARY

This PR adds a feature for users to change the Job Type (run type) on relaunching the job.

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • API
  • UI
AWX VERSION
23.6.1.dev29+g02f77b54af
ADDITIONAL INFORMATION

Before this change, modifying the run type required creating a new job, which could be inconvenient, especially for jobs with numerous prompts. The aim is to improve the user experience by allowing users to choose the run type while relaunching the job.

I decided to use a dropdown instead of modal (modal was suggested in the issue). By implementing a dropdown instead of a modal, we avoid potential negative impacts on the user experience. The dropdown was chosen as it is already used for failed jobs, providing a consistent interface.

I have tested this feature thoroughly on job_list, job_detail, and job_output screens.


Sasa993 avatar Feb 02 '24 12:02 Sasa993

In order for this modal to activate, does prompt on launch for job type need to be enabled?

Also, do you mind providing screenshots of the modal as well so that when we test this we know what to look for?

thedoubl3j avatar Feb 07 '24 20:02 thedoubl3j

In order for this modal to activate, does prompt on launch for job type need to be enabled?

Also, do you mind providing screenshots of the modal as well so that when we test this we know what to look for?

I used a dropdown instead of modal.

Here are the screenshots of all three places where job relaunch is present: job-details job-output job-list

Sasa993 avatar Feb 09 '24 09:02 Sasa993

thanks for the screenshots @Sasa993

still wondering though if prompt on launch for job type need to be enabled for this drop down to be available?

@fosterseth have you had a chance to test this?

thedoubl3j avatar Feb 14 '24 20:02 thedoubl3j

if Relaunch button now evokes a dropdown, we probably will want to change button to have an arrow, similar to the Add button on the job template page

image

As for the job list view -- I think the relaunch button (the space shuttle button) should be the old behavior so that relaunching is still a 1 click operation. The dropdown menu would only be for the Relaunch button on the Job detail page. We'd need a UI engineer to chime in on this point

fosterseth avatar Feb 15 '24 18:02 fosterseth

thanks for the screenshots @Sasa993

still wondering though if prompt on launch for job type need to be enabled for this drop down to be available?

@fosterseth have you had a chance to test this?

No, prompt on launch for job type doesn't need to be enabled. Thank you for taking the time to review this.

Sasa993 avatar Feb 16 '24 07:02 Sasa993

if Relaunch button now evokes a dropdown, we probably will want to change button to have an arrow, similar to the Add button on the job template page

image

As for the job list view -- I think the relaunch button (the space shuttle button) should be the old behavior so that relaunching is still a 1 click operation. The dropdown menu would only be for the Relaunch button on the Job detail page. We'd need a UI engineer to chime in on this point

That's a good point, I totally agree. I'll adjust that as soon as I get the "green light" from someone on the UI team. Thanks for taking a look at this.

Sasa993 avatar Feb 16 '24 07:02 Sasa993

Marking as draft till CI issues are resolved

dmzoneill avatar Feb 19 '24 14:02 dmzoneill

putting into Blocked until we can get feedback from a UI or UX developer

fosterseth avatar Feb 28 '24 20:02 fosterseth

Closed in favor of #15249

Sasa993 avatar Jun 05 '24 07:06 Sasa993