awx icon indicating copy to clipboard operation
awx copied to clipboard

Published 20 hours ago • verified publisher icon ansible

Add support of update_on_project_update in inventory_source

Open Sispheor opened this issue 1 year ago • 1 comments

SUMMARY

The flag update_on_project_update was missing from inventory_source module.

Api ref: https://docs.ansible.com/ansible-tower/latest/html/towerapi/api_ref.html#/Inventories/Inventories_inventories_inventory_sources_create

ISSUE TYPE

New or Enhanced Feature

COMPONENT NAME
  • Collection

Sispheor avatar Sep 08 '22 12:09 Sispheor

Pr updated.

  • PR body updated
  • Flag added to the E2E test

Sispheor avatar Sep 15 '22 14:09 Sispheor

Thank you so much for your contribution, it really means a lot to us. After further investigation, it looks like update_on_project_update was a field in the modules for quite some time but was recently removed in June of this year from the API and also the collection. At this time we don't want to add the parameter back in because the version of the collection should match the version of the API it was released with. Please let us know if you have a different opinion about this. If not, we will close this PR.

john-westcott-iv avatar Oct 04 '22 13:10 john-westcott-iv

Indeed it has been removed... And so this PR is not needed. The new behavior based only on "update_no_launch" is not very good but I guess that we'll have to live with it.

Thanks for your time anyway guys. I close this one.

Sispheor avatar Oct 04 '22 13:10 Sispheor