awx icon indicating copy to clipboard operation
awx copied to clipboard

Added domain entry and authorizer for TSS

Open vician opened this issue 2 years ago • 3 comments

SUMMARY

Adding domain option to Thycotic SecretServer credential plugin.

We hope this would get into Ansible Automation Platform as well.

ISSUE TYPE
  • Enhanced Feature
  • New or Enhanced Feature
COMPONENT NAME

awx/main/credential_plugins/tss.py

AWX VERSION
21.4.0
ADDITIONAL INFORMATION

It's very similar to approach of community.general.tss here https://github.com/ansible-collections/community.general/pull/3228

vician avatar Aug 05 '22 13:08 vician

How can we get this reviewed please?

vician avatar Sep 05 '22 11:09 vician

Our apologies for the delay. I am going to close and reopen this PR to see if I can get the checks to properly run.

john-westcott-iv avatar Sep 14 '22 19:09 john-westcott-iv

Thank you. Pipeline is passing.

vician avatar Sep 14 '22 20:09 vician

We hope this would get into Ansible Automation Platform as well.

Hey @vician do you have any contacts for Integrations at Thycotic/Delinea that can reach out to the Ansible partners team? Getting this integration (and future ones) in front of them will better position this PR to get downstream.

thedoubl3j avatar Sep 28 '22 19:09 thedoubl3j

@thedoubl3j How can they reach Ansible partners team, please?

vician avatar Sep 30 '22 15:09 vician

@vician [email protected] is the alias for the team.

thedoubl3j avatar Sep 30 '22 18:09 thedoubl3j

@vician I failed to verify plugin with the our secretservercloud server. I have a local user configured there. When I click Test, I'm getting ClientError:

image

I'm using docker development environment. Got this log:

tools_awx_1 | awx-uwsgi stderr | 2023-04-13 17:30:33,931 WARNING  [4f08de1e] awx.api.generics status 400 received by user obaranov attempting to access /api/v2/credentials/84/test/ from 172.18.0.1
tools_awx_1 | awx-uwsgi stderr | 
tools_awx_1 | awx-uwsgi stderr | 2023-04-13 17:30:33,939 WARNING  [4f08de1e] django.request Bad Request: /api/v2/credentials/84/test/
tools_awx_1 | awx-uwsgi stderr | 2023-04-13 17:30:33,939 WARNING  [4f08de1e] django.request Bad Request: /api/v2/credentials/84/test/
tools_awx_1 | awx-uwsgi stderr | 
tools_awx_1 | awx-uwsgi stderr | [pid: 389|app: 0|req: 8/42] 172.18.0.1 () {60 vars in 1173 bytes} [Thu Apr 13 17:30:33 2023] POST /api/v2/credentials/84/test/ => generated 36 bytes in 466 msecs (HTTP/1.1 400) 16 headers in 621 bytes (1 switches on core 0)
tools_awx_1 | awx-uwsgi stderr | 

I tested the same URL, username and password with the ansible lookup plugin. And it worked:

  - debug:
      msg: "{{
              lookup(
                  'community.general.tss',
                  3,
                  base_url=base_url,
                  username=username,
                  password=password,
                  domain=''
              )
          }}"
          ```
          
Any ideas what could be wrong?           

obaranov avatar Apr 13 '23 17:04 obaranov

@obaranov i don’t think your issue is related to this pull request. The whole integration is outdated. I might find some more time to open new PR for that but I don’t have environment to test the changes at the moment.

vician avatar Apr 18 '23 19:04 vician