awx icon indicating copy to clipboard operation
awx copied to clipboard

Correct help text for job idle timeout

Open AlanCoding opened this issue 3 years ago • 0 comments

SUMMARY

I established experimentally that this help text was wrong. Steps to show this:

  • run a job that has a command: task sleep for 700 seconds
    • find that it is successful
  • PATCH the /api/v2/settings/jobs/ page to set DEFAULT_JOB_IDLE_TIMEOUT to 600
  • re-launch the job
    • find that it fails with a timeout

Looking into the origin of this, it seems that someone mistook the ansible-runner example data for the default value. Following the ansible-runner code, it's pretty clear that providing no value of idle_timeout results in no idle timeout being enforced. AWX has code that will not provide the idle_timeout param if the setting's value is 0.

https://github.com/ansible/awx/blob/78660ad0a22798ace9210b37ba5be9429603e49d/awx/main/tasks/jobs.py#L518-L520

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME
  • API

AlanCoding avatar May 26 '22 18:05 AlanCoding