awx icon indicating copy to clipboard operation
awx copied to clipboard

Improve Slack Notification Error Handling

Open wwitzel3 opened this issue 7 years ago • 2 comments

ISSUE TYPE
  • Enhancement
COMPONENT NAME
  • API
  • UI
SUMMARY

Currently we only surface errors when sending slack notification if a Python exception occurs. We could do better if we read the event stream after our rtm_send_message call to see if there were any error events waiting.

A common error is when the bot has not been invited to a channel that we are attempting to send the notification to. This can be caught in the message stream, but does not throw an exception.

ADDITIONAL INFORMATION

https://github.com/ansible/awx/blob/devel/awx/main/notifications/slack_backend.py#L49

wwitzel3 avatar Jan 24 '18 14:01 wwitzel3

Hi @wwitzel3, I would like to take up this issue. Can you please assign it to me?

tanujdevops avatar Sep 06 '22 17:09 tanujdevops

No one is actively working on it. Just do the work and submit a PR

matburt avatar Sep 08 '22 00:09 matburt