awx-operator
awx-operator copied to clipboard
ansible
feat: Add ingress_class_name parameter
Related to #716
Hello, I added ingressClassName parameter compatibility in ingress template.
Great to see this being added :+1:
I tried your new chart, and works fine for me on a kubespray cluster, v1.21.6
Well, for some reason the test to actually create the AWX cluster with this flag set failed.
I've resolved the conflict and pushed to this branch. I was going to merge it, but the last comment about the deployment failing has me concerned. Will wait for more eyes on this.
I tried to install and I faced the same problem. I don't have (or want to have) a default ingress, so this feature would be nice.
Against 0.21 the modifications to ingress.yaml.j2 are in the wrong location. The should be a bit higher and not indented as far:
spec: {% if ingress_class_name %} ingressClassName: {{ ingress_class_name }} {% endif %} rules:
Hi @shanemcd, @aperigault thanks for your works ! we are interested on this PR we use massively awx on k8s. Let we know if you need some help on it.
@aperigault can you please address the indentation mistake that has been pointed out? The key is supposed to be directly under the spec key and not part of any of subordinate keys in the spec.
I really need this to be added ASAP or I won't be able to deploy AWX using the operator. I was about to patch this myself but I see that this has already gotten some traction and I hope that it can be merged swiftly.
This is how I would do it:
spec:
{% if ingress_class_name %}
ingressClassName: '{{ ingress_class_name }}'
{% endif %}
rules:
Since there's no action on this one, I've opened a new one which does not contain the bad indentation. I really need this fix and I will be responding to comments in the PR I opened.
These changes merged as part of https://github.com/ansible/awx-operator/pull/977/files, which also had the needed CSV parameter entries.
