Custom pod labels
This should resolve #563. If/when this passes muster, I'll squash so it can be merged.
Hi, sorry for the slow review. Looks like this has conflicts now. Once you fix, we'll get this reviewed and merged.
Hi, sorry for the slow review. Looks like this has conflicts now. Once you fix, we'll get this reviewed and merged.
No problem @shanemcd -- I've gone ahead and rebased on devel without conflicts as requested, and squashed down to one commit.
EDIT: whoops, I forgot to pull upstream before rebasing, and my fork wasn't up-to-date, so I'll get that fixed quickly...
Any chance we can get this merged ?
I am having the same problem. #1160 must resolve issue. waiting for merge
additional labels was implemented in this PR https://github.com/ansible/awx-operator/pull/1160
does that PR address the use case you had in mind @philipsd6
@fosterseth I believe it does, as PR #1160 enables setting additional_labels which as I understand it would then apply (from the example in my README) update prometheus.io/scrape-awx to the pods, which was our use-case for this PR. However, the additional_labels solution will also apply it to the service as well, but I can't see why that would be a problem, so I would consider our use-case met by PR #1160.