awx-operator icon indicating copy to clipboard operation
awx-operator copied to clipboard

chore: added aggregate labels to ClusterRoles with kustomize

Open myles-coleman opened this issue 1 year ago • 1 comments

SUMMARY

We want to add user-facing roles to awx ClusterRole resources. This would allow our users to automatically view/manage these resources without an admin needing to craft custom role bindings.

Cert-Manager Example

Another operator that does this is cert-manager. Here is an issue from cert-manager where they handle a similar problem. They only create the aggregate ClusterRoles if the global.rbac.aggregateClusterRoles value is set to true in their values.yaml.

ISSUE TYPE
  • New or Enhanced Feature
ADDITIONAL INFORMATION

This PR will certainly change current state behavior, possibly granting new permissions to people who update as these ClusterRoles previously had to be specifically installed. An alternative to this would be providing a kustomize patch file which can add these roles, so that people can opt-in instead of automatically being granted these permissions.

myles-coleman avatar Jul 05 '24 19:07 myles-coleman

cc @rcarrillocruz @TheRealHaoLiu What do you think about this?

rooftopcellist avatar Jul 10 '24 18:07 rooftopcellist