awx-operator icon indicating copy to clipboard operation
awx-operator copied to clipboard

Published 20 hours ago • verified publisher icon ansible

Added PodSpec for DNS config,policy and Hostnetwork for rsyslog/redis/ee/task/init and web containers.

Open rakesh561 opened this issue 1 year ago • 11 comments

SUMMARY

Added PodSpec for DNS config,policy and Hostnetwork for rsyslog/redis/ee/task/init and web containers.

ISSUE TYPE
  • New or Enhanced Feature
ADDITIONAL INFORMATION

This will address the following #479 issue

rakesh561 avatar Jun 29 '23 19:06 rakesh561

Is there a particular use case for doing this for Rsyslog?

Are you planning to add these fields as configurable for the task/web deployments?

rooftopcellist avatar Jul 05 '23 18:07 rooftopcellist

I'm planning to apply for task/web and redis.I will update the PR by end of today

rakesh561 avatar Jul 05 '23 18:07 rakesh561

@rooftopcellist Updated the PR for all the containers

rakesh561 avatar Jul 05 '23 22:07 rakesh561

@rooftopcellist removed the init container from the config

rakesh561 avatar Jul 12 '23 18:07 rakesh561

@rakesh561 do you have a podspec(s) that we can use as an example when testing this out locally?

also can you please take a look at the above CI failures?

fosterseth avatar Aug 23 '23 18:08 fosterseth

@rakesh561 It looks like CI is failing, before merge a couple things need to happen:

  • the branch needs to be rebased
  • CI needs to be passing
  • It would be helpful to have samples added to config/samples or just an example in a comment here for testing the changes out.

rooftopcellist avatar Sep 27 '23 18:09 rooftopcellist

@rakesh561 The CI is failing when applying the task deployment because of an extra closing brace somewhere:

task path: /opt/ansible/roles/installer/tasks/resources_configuration.yml:248\\nfatal: [localhost]: FAILED! => {\\\"msg\\\": \\\"An unhandled exception occurred while running the lookup plugin 'template'. Error was a <class 'ansible.errors.AnsibleError'>, original message: template error while templating string: unexpected '}'

rooftopcellist avatar Dec 13 '23 20:12 rooftopcellist

@rooftopcellist thanks for finding them i have remove those extra braces

rakesh561 avatar Dec 13 '23 20:12 rakesh561

@rooftopcellist let me know wat you think also in between i was off couldn't get back to contribution.

rakesh561 avatar Dec 13 '23 22:12 rakesh561

Hi @rakesh561 I think the generic override pattern suggested in https://github.com/ansible/awx-operator/issues/479 is a better way to address your need and a lot more different needs for other people

TheRealHaoLiu avatar Jan 10 '24 19:01 TheRealHaoLiu

https://github.com/ansible/awx-operator/pull/1695

@rakesh561 try this out it should allow you to override the bits you want

TheRealHaoLiu avatar Jan 24 '24 22:01 TheRealHaoLiu