awx-operator icon indicating copy to clipboard operation
awx-operator copied to clipboard

Implement extra sidecar support

Open Yomanz opened this issue 2 years ago • 12 comments

SUMMARY

This PR adds a new property that allows you to specify sidecars to add to the AWX pod as blocks within the config.

Fixes https://github.com/ansible/awx-operator/issues/1235

ISSUE TYPE
  • New or Enhanced Feature
ADDITIONAL INFORMATION

This is useful for people who might need to add a VPN or other extra functionality to awx while using the awx-operator.

Yomanz avatar Feb 11 '23 15:02 Yomanz

@Yomanz Could you add some documentation in the README.md on how to use this in this PR? In that section, could you also add some potential use cases?

Otherwise, I think this looks good. Feel free to join our next community meeting to share this with others in the community!

  • https://github.com/ansible/awx/issues/13563

rooftopcellist avatar Feb 15 '23 19:02 rooftopcellist

@Yomanz Could you add some documentation in the README.md on how to use this in this PR? In that section, could you also add some potential use cases?

Otherwise, I think this looks good. Feel free to join our next community meeting to share this with others in the community!

* [AWX Office Hours Agenda - Mar 14 2023 awx#13563](https://github.com/ansible/awx/issues/13563)

I will add some documentation, yeah.

Yomanz avatar Feb 16 '23 15:02 Yomanz

Hey @Yomanz , are you still interested in adding a README.md entry here?

rooftopcellist avatar Mar 01 '23 19:03 rooftopcellist

Are there any update with this feature? We were looking for the same feature. It will be good if it can be implemented

ghost avatar Mar 20 '23 22:03 ghost

@WenboDu1228 would you be interested in adding docs for this feature with some use case(s)? Then we can consider this feature complete and merge (code looks good and works as is).

It could be on a separate PR.

rooftopcellist avatar Mar 22 '23 18:03 rooftopcellist

Hi @Yomanz thanks for your contribution and welcome to the AWX community.

Recently there's been some big changes in the AWX operator and AWX, we split up the task and web deployment

for this feature to go forward can you implement the sidecar for both web and task container following how we handled the replicas parameters

TheRealHaoLiu avatar Aug 09 '23 18:08 TheRealHaoLiu

What is the delay with getting this merged and publishing a new release with this feature? I and several others need this functionality. Can we please dispense with the foot-dragging and get it done?

roncemer avatar Aug 14 '23 14:08 roncemer

Hi @Yomanz thanks for your contribution and welcome to the AWX community.

Recently there's been some big changes in the AWX operator and AWX, we split up the task and web deployment

for this feature to go forward can you implement the sidecar for both web and task container following how we handled the replicas parameters

I can look into doing this 👍

Yomanz avatar Aug 14 '23 15:08 Yomanz

Hey @TheRealHaoLiu and @Yomanz, I am willing to takeover if it is ok with you. I can continue on @Yomanz 's work and make the changes for the separation between web and task pods. I think I would need to create a new PR for this and close this one.

sey avatar Jan 02 '24 10:01 sey

Hey @TheRealHaoLiu and @Yomanz, I am willing to takeover if it is ok with you. I can continue on @Yomanz 's work and make the changes for the separation between web and task pods.

I think it would need to create a new PR for this and close this one.

Yeah crack on that'd be great, I did plan to finish this but I just ran out of time for it unfortunately.

Yomanz avatar Jan 02 '24 10:01 Yomanz

If we implement and overrides feature like describe in https://github.com/ansible/awx-operator/issues/479, that would allow for injection sidecar containers as well.

rooftopcellist avatar Jan 17 '24 19:01 rooftopcellist

hey @Yomanz https://github.com/ansible/awx-operator/pull/1695 try this out it should allow you to inject extra sidecars

TheRealHaoLiu avatar Jan 24 '24 22:01 TheRealHaoLiu