awx-operator icon indicating copy to clipboard operation
awx-operator copied to clipboard

Published 20 hours ago • verified publisher icon ansible

Added pg_dump_suffix doc and crd property

Open MathijsVanWilligen opened this issue 2 years ago • 3 comments

Fixes: #958

SUMMARY

Add documentation for the 'pg_dump_suffix' parameter. Also add this option to the awxbackup crd properties so it can be used inside the crd. Without a definition inside the crd we won't be able to use the 'pg_dump_suffix' parameter.

ISSUE TYPE
  • Bug or Docs Fix

MathijsVanWilligen avatar Aug 01 '22 09:08 MathijsVanWilligen

Let add a known working example of the parameter? You encountered some special formatting upon table-data exclusion?

sdktr avatar Aug 01 '22 16:08 sdktr

Let add a known working example of the parameter? You encountered some special formatting upon table-data exclusion?

Like this @sdktr? 977e08e6882f4a771948beb75c8ca04e6a180fca

MathijsVanWilligen avatar Aug 02 '22 06:08 MathijsVanWilligen

LGTM!

sdktr avatar Aug 02 '22 11:08 sdktr

Can you merge this @shanemcd , it enhances PR #958

sdktr avatar Oct 10 '22 14:10 sdktr

@dsavineau / @CFSNM ? or other maintainers available to check this out?

sdktr avatar Oct 23 '22 09:10 sdktr

@MathijsVanWilligen Could you please rebase this? Sorry for the delay, we are going through old PR's and this looks like a good candidate for merge.

rooftopcellist avatar Dec 07 '22 19:12 rooftopcellist

Hi @rooftopcellist, thanks for your reply. I have rebased my branch onto awx-operator/devel. I hope it went well, this is my first time for an open-source project ;-)

MathijsVanWilligen avatar Dec 08 '22 15:12 MathijsVanWilligen

FYI to anyone wondering, this PR is follow-up for this other PR which introduced the pg_dump_suffix variable:

  • https://github.com/ansible/awx-operator/pull/980/files

Thanks for making this configurable via the AWX spec @MathijsVanWilligen !

rooftopcellist avatar Dec 14 '22 19:12 rooftopcellist