allow automerge on module PRs with tests.

[jctanner]

https://github.com/ansible/ansible/pull/31607

This is definitely necessary if we are demanding new tests with every PR.

[bcoca]

Just raised this issue in testing meeting, seems we all are for 'automerge' working with modules + matching tests.

[gundalow]

• Only if test/integration/target/$modulename/ (not just anything with label:test, for example we don't want automerge on changes to test/runner)
• Should also apply to test/units//$modulename/

[andreaso]

Perhaps also corresponding rules for ./test/legacy/?

[gundalow]

@andreaso Good point, thank you

[gundalow]

Note to self: Need to define a clear set of rules for this

[gundalow]

As part of this work we should apply any labels that the corresponding module (or plugin/module_util would have added.

ie

1. change to test/integration/target/nxos_command should result with:

• label networking as modules/network/nxos/nxos_command's BOTMETA has label:networking
• Notify $team_nxos, again via BOTMETA entry for the module
• support:network, again via BOTMETA entry for the module

2. Same for test/legacy/roles/{module}

3. Same for test/units/modules/

4. change to test/units/plugins/httpapi/ Match BOTMETA for lib/ansible/plugins/connection/httpapi.py

• support: network
• label: network
• maintainers: $team_networking

This also means that the shipit/merge rules for the code itself apply to the test code

[gundalow]

See also https://github.com/ansible/ansibullbot/issues/811

[felixfontein]

Currently it seems that some module-only PRs with accompanied tests can't be automerged: https://github.com/ansible/ansible/pull/44789#issuecomment-424976045

(I later modified the PR and added some changelog fragment, which is known to block automerge anyway currently... But at the time of that bot_status comment, all conditions for automerge were fulfilled IMO.)

[resmo]

blocking module automerges because of updated tests, bites me again.