ansibullbot icon indicating copy to clipboard operation
ansibullbot copied to clipboard

shipit command ignored when a pull request updates 'module_utils' only

Open pilou- opened this issue 6 years ago • 1 comments

Shipit/reviews are ignored when a pull request only updates module_utils.

Non module change are approved by the core team but:

  • shipit from core team for pull requests updating only module_utils should be taken in account
  • currently, pull requests updating a module and module_utils can be labeled with shipit (example)
  • taking in account shipit command from maintainers and automatically adding shipit label could ease the workload of the core team (core team could focus on shipit labeled pull requests only).

pilou- avatar Sep 08 '17 08:09 pilou-

Seeing what appear to be the same issue here: https://github.com/ansible/ansible/pull/66914 bot_status: waiting_on: maintainer <== this appears to be wrong changes_requested_by: null needs_info: False needs_revision: False needs_rebase: False merge_commits: [] too many files or commits: False mergeable_state: clean shippable_status: success maintainer_shipits (module maintainers): 4 community_shipits (namespace maintainers): 0 ansible_shipits (core team members): 0 shipit_actors (maintainers or core team members): sile16 genegr dnix101 sdodsley shipit_actors_other: [] automerge: automerge is_module test failed <== error here

sdodsley avatar Jan 31 '20 20:01 sdodsley