ansibullbot
ansibullbot copied to clipboard
ansible
Hide older CI failures comments from PR history
It would be nice if ansibot could remove older CI failures from the history. Currently they can make the history quite loaded with old irrelevant (and sometimes incorrect) stuff.
@dagwieers I don't completely agree. It can be nice to see the progression of a PR. However, the feature was implemented at the request of @mattclay so I'll let him decide.
I don't see what is nice from keeping this: https://github.com/ansible/ansible/pull/25529
Most people don't know this is no longer relevant and you get tweets like: https://twitter.com/luiscerezo/status/873148864034881536
Personally, I prefer not seeing the errors in the discussion. But I can see the benefit for less active users, as they get an email and they don't have to hunt it down. Still it looks more like a wall of shame, this module was near-perfect except for a python 2.6 issue, PEP8 and doc formatting issues. And what do you see from ansibot, old pain :-/ It's already bad that it took 5 feedback-cycles to get it right (because the doc format check only shows a single issue at a time).
I understand wanting to minimize the noise in the PR comments. However, just like outdated comments by humans, it can be useful to have older comments to see the progression of a PR.
One area where we might be able to improve things is to change how the bot comments on CI failures. Instead of creating a regular comment, we could have the bot use review comments so each comment is associated with a specific line in a specific commit.
The upside of that would be that just like outdated human comments on reviews, CI failures would largely be hidden as they became obsolete. The downside is that it would also make the feedback more verbose and possibly less useful in the email notifications. We'd need to experiment to see if it would be an improvement or not.
It definitely is not a priority.
PS I don't know what the value to others is that there was a syntax error, or a faulty integration script. If you can test locally you would be fixing those things and there was no paper trail and nobody would care. If those things are fixed, why bother ? It's just wasting everyone's time IMO because it may deflect others from what is important in the review process. Rather than "more information" it's "more ballast".
Because this ticket hasn't been updated despite discussions elsewhere. The obvious solution here is to hide older comments as Resolved or Outdated, this way the information is still available without being too noisy. I was told the GitHub API at that time did not support hiding comments.
https://developer.github.com/v3/issues/comments/
You can now hide comments via GitHub's API:
- https://developer.github.com/v4/mutation/minimizecomment/
- https://developer.github.com/v4/input_object/minimizecommentinput/
ReportedContentClassifiers = OUTDATED https://developer.github.com/v4/enum/reportedcontentclassifiers/
@mattclay would hiding (hide/outdated) on older CI messages be OK? The messages are still there, and anyone can view them, they just aren't shown by default.
I think that should make viewing a PR easier
