ansibullbot icon indicating copy to clipboard operation
ansibullbot copied to clipboard

callback plugins require more that a maintainer shipit comment.

Open rrey opened this issue 5 years ago • 0 comments

Hi,

in bot help page the following can be read for merge conditions on community maintained modules:

If you are maintainer of the module or maintainer of a module in the same namespace, only one shipit is required.

It seems that the behavior is not applied on callback plugins. Here are 2 PR where I am maintainer of the callback, and my shipit comment was not enough to trigger the bot shipit labeling: https://github.com/ansible/ansible/pull/57629 https://github.com/ansible/ansible/pull/57575

I had to ask for help on IRC. Is there a reason for not applying the same merge conditions on callbacks ?

rrey avatar Jul 14 '19 14:07 rrey