ansible
Add test for 256-color configuration values
This commit https://github.com/ansible/ansible/pull/78613/commits/03654a2a499b34c385efafeb3379db4c16101c38 effectively disabled the tests.
Yeah, the xfail mark means “expected to fail”. The fixer of the bug is supposed to remove the mark.
just add the commit from my PR to this one and revert the xfail (that makes it easier to backport as a single unit)
I assume by “my PR” you’re referring to #78617, but you accidentally the verb. Do you mean “add the commit from #78617 and revert the xfail”?
I assume by “my PR” you’re referring to #78617, but you accidentally the verb. Do you mean “add the commit from #78617 and revert the xfail”?
I suppose so. You could first cherry-pick Brian's commit, ensure that the test starts failing (because xfail_strict produces a failure on XPASS — https://blog.ganssle.io/articles/2021/11/pytest-xfail.html). And then, do git revert as a finishing bit.
This commit 03654a2 effectively disabled the tests.
It did not. xfail is not the same as skip. It does run the test (unless you set run=False) and then it makes sure that it fails (strict=True) makes it fail when it starts passing so when the problem is actually fixed, you get notified loudly.
@yurikhan yes, just add my commit/copy the code here and revert the xfail change
Seeing as I’m rebasing the branch to current devel anyway, I just dropped the commit that marked the test with xfail.
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
Do test suite changes deserve a changelog entry, or should I describe the bug fixed instead?
Will look into it this coming weekend.
@yurikhan Only the bug fix requires a changelog entry. Unit test changes should not be in the changelog.