ansible-lint

ansible-lint copied to clipboard

ssbarnea

Quick PR to address my feedback in https://github.com/ansible/ansible-lint/pull/2263#pullrequestreview-1067565024

cognifloyd

TODO: - [ ] Improve dumping templates that need to be wrapped due to length - [ ] Add more test cases - [ ] Reword the PR description -...

cognifloyd

name[imperative]: All task names should be written in the imperative

1

Starting to pull in possible rule ideas from the community of practice: https://github.com/redhat-cop/automation-good-practices/pull/64 A task in a task file or play performs an action, the name of the task should...

cidrblock

yaml[line-length] rule can't be skipped when the triggering line is in a YAML block scalar

2

##### Summary For readability and line length reasons I prefer folding long lines using YAML's block scalar functionality, however the yaml[line-length] rule can't seem to be skipped using no-qa comment...

brlin-tw

Local collection install conflict between ansible-lint and molecule

3

##### Summary It appears there is a conflict with how molecule and ansible-lint install a project if it is a collection. Molecule uses `ansible-galaxy` to install the collection in the...

aldehir

selecting profiles on the command-line requires "="

2

##### Summary Selecting profiles on the command-line doesn't work with "-P profile", only with "-P=profile". This doesn't work: ``` ansible-lint -P basic test.yml ansible-lint: error: argument -P/--profile: invalid choice: 'test.yml'...

andreby

False positive load-failure when using import_tasks / include_tasks inside a block

4

##### Summary PR #2202 for #1446 fixed many false `load-failure` violations we have. However, it seems the fix doesn't handle cases when `include_tasks` is placed inside a `block`. ##### Issue...

to-bar

single-entry-point: identify role with possible multiple entry points

8

Valid: - only one `main.yml` file - all other files have `_` prefix - all other files are in subdirectories Invalid: - multiple files in tasks/ Reasonint: We want to...

ssbarnea

use-loop: Disallow the use of `with_xxx` as a looping mechanism

4

The use of with_ is "discouraged" and "loop" is preferred. Although with_ is not deprecated, this would be a good optional rule for people wanting to future proof their playbooks.

cidrblock