ansible-documentation icon indicating copy to clipboard operation
ansible-documentation copied to clipboard

remove old ad

Open samccann opened this issue 1 year ago • 7 comments
trafficstars

The Ad at the bottom left of docs pages stopped working when ansible.com was revamped, so ...time to remove it!

samccann avatar Sep 11 '24 20:09 samccann

Hmm. Is it just me or is the left nav cut off at the bottom?

image

oraNod avatar Sep 12 '24 08:09 oraNod

I've kicked off a run to deploy this branch to test: https://github.com/ansible/ansible-documentation/actions/runs/10827409830

oraNod avatar Sep 12 '24 08:09 oraNod

Yeah it looks like the left nav is truncated on stage too: https://ansible-community.github.io/package-doc-builds/

oraNod avatar Sep 12 '24 09:09 oraNod

Closed and re-opened to check the RTD preview build. It looks like there's still a reference to the stage-ansible-core project alongside the new ansible-core project.

oraNod avatar Sep 12 '24 10:09 oraNod

Closing this - the problem I think is in the sphinx ansible theme itself - https://github.com/ansible-community/sphinx_ansible_theme/blob/main/src/sphinx_ansible_theme/extranav.html

So will remove the ad from there.

samccann avatar Sep 16 '24 16:09 samccann

@samccann It might still be worth removing that line from the conf file after you make the change to the sphinx theme.

oraNod avatar Sep 16 '24 17:09 oraNod

A good point.

samccann avatar Sep 16 '24 17:09 samccann