Issue1682_nightly_build_default_values
Initial pass at adding default values for scheduled runs.
I don't have a lot of the environment/secrets data to validate that these are correct/would run, so I'd apprecaite review by someone who has access to those or a fork that can better test these.
For issue #1682
Thanks for looking into this @x1101 - Things are a little hectic this week but I'm hoping to find some time to look at this soon and will give you a shout. :tanabata_tree:
thanks for looking at this again @x1101 the defaults here allow scheduled runs to work so we can turn on nightly builds. e.g. https://github.com/oraNod/ansible-documentation/actions/runs/10559183999
one wrinkle in this is with the step to log workflow inputs: https://github.com/ansible/ansible-documentation/blob/4efd295360d20c21f942029123c94b8d09377b9f/.github/workflows/build-package-docs.yaml#L113
this has the if: fromJSON(github.event.inputs.deploy) conditional. the value for github.event.inputs.deploy doesn't get set on a schedule (even if you specify a default under inputs). this causes the step to fail with:
Error: The template is not valid. Newtonsoft.Json.JsonReaderException: Error reading JToken from JsonReader. Path '', line 0, position 0.
and the build job fails as a knock on effect. I think maybe we can just move that step to the deploy job. I'll send a separate PR but wanted to mention it here in case anyone else notices. we'll need to get that fixed before we apply a schedule.
I also noticed that the language option wasn't fully removed and the env was left over. I've created https://github.com/ansible/ansible-documentation/pull/1804