ansible-documentation icon indicating copy to clipboard operation
ansible-documentation copied to clipboard

Muni tech writers: Ansible include_task search documentation incorrect #357

Open vojtam opened this issue 3 months ago • 2 comments

Hi, this (draft) PR concerns the issue #357 and addresses the comments made to the previous PR #1263 I have made the changes suggested and requested in the comments, and I hope that this one is in better shape.

mainly, I pulled the information about the distinction between the contexts that are used for lookups under a single note to (hopefully) make it compliant with the comment https://github.com/ansible/ansible-documentation/pull/1263#discussion_r1567565138

vojtam avatar Apr 24 '24 14:04 vojtam

@vojtam Hi, I've pushed a commit to your branch.

@bcoca Could you please take another look and let us know if you have any final nits? Thanks!

oraNod avatar May 14 '24 16:05 oraNod

@bcoca Aloha. Thanks for all the reviews so far on this one. Hopefully we've got it all sorted now. If you could take one last look and approve, we'd appreciate it. Cheers.

oraNod avatar May 17 '24 09:05 oraNod

Backport to stable-2.15: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.15/c216a1a9e874dbf0698ef8634089be6040379dec/pr-1321

Backported as https://github.com/ansible/ansible-documentation/pull/1511

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar May 22 '24 13:05 patchback[bot]

Thanks very much for the docs contribution @vojtam :tada:

oraNod avatar May 22 '24 13:05 oraNod

Backport to stable-2.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.14/c216a1a9e874dbf0698ef8634089be6040379dec/pr-1321

Backported as https://github.com/ansible/ansible-documentation/pull/1512

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar May 22 '24 13:05 patchback[bot]

Backport to stable-2.16: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.16/c216a1a9e874dbf0698ef8634089be6040379dec/pr-1321

Backported as https://github.com/ansible/ansible-documentation/pull/1513

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar May 22 '24 13:05 patchback[bot]

Backport to stable-2.17: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.17/c216a1a9e874dbf0698ef8634089be6040379dec/pr-1321

Backported as https://github.com/ansible/ansible-documentation/pull/1514

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar May 22 '24 13:05 patchback[bot]