ansible-builder icon indicating copy to clipboard operation
ansible-builder copied to clipboard

Support PIP_OPTs for python-builder-image

Open pabelanger opened this issue 3 years ago • 3 comments

We added support to python-builder-image, which allows a user to pass pip options via PIP_OPTs:

https://github.com/ansible/python-builder-image/pull/34

In the case of downstream builds, we set --no-build-isolation for reproducible builds. Additionally, it would allow upstream users to pass:

--no-binary :all:

Which disabled use of pre-compiled wheels, again getting upstream builds closer to downstream / offline supported.

pabelanger avatar Apr 30 '21 17:04 pabelanger

How would users pass this option to ansible-builder? Would it be in the execution environment definition?

AlanCoding avatar May 25 '21 19:05 AlanCoding

I imagined it working the same way we did the galaxy opts setting

pabelanger avatar May 25 '21 20:05 pabelanger

so a build arg.

The assemble script also takes, in some sense, CONSTRAINTS, PACKAGES, and others. I don't fully understand those options.

In my imagination, this would follow an ARG and then ENV pattern in the Containerfile. That wouldn't get messy if we add more later.

AlanCoding avatar May 26 '21 00:05 AlanCoding

@AlanCoding @Shrews I created a PR that will add this param. In the PR I wrote why we need this tipe of arg

Thanks

tanganellilore avatar Apr 05 '23 10:04 tanganellilore

I'm going to go ahead and close this. We just merged support for a new EE format that has features that would allow you highly customize any of the builder build phases (e.g., the new additional_build_steps section).

Shrews avatar Apr 05 '23 11:04 Shrews