cisco_ios icon indicating copy to clipboard operation
cisco_ios copied to clipboard

add functionality to pass templates

Open jwoogee opened this issue 6 years ago • 8 comments

I have a PR on config_manager to add this functionality. This allows user to pass through list of templates to load. I also fixed spacing issue in run_cli task.

jwoogee avatar Dec 19 '18 22:12 jwoogee

Build failed.

Can someone take a look at this one?

jwoogee avatar Dec 28 '18 17:12 jwoogee

@trishnaguha Sorry to tag you, is there someone or some group I should tag when submitting a PR? I just want to make sure I'm doing it right.

jwoogee avatar Dec 31 '18 14:12 jwoogee

@jwoogee it looks like you need to add a new line to the end of the file, per the CI linter failure:

https://object-storage-ca-ymq-1.vexxhost.net/v1/a0b4156a37f9453eb4ec7db5422272df/logs/84/84/4a438fed6ceba158f83149673900ce1b17370142/check/tox-linters/97dd084/job-output.html

rcarrillocruz avatar Jan 14 '19 14:01 rcarrillocruz

Thank you, I fixed that error.

jwoogee avatar Jan 14 '19 14:01 jwoogee

Build succeeded.

@justjais can you take a look at this to review?

abenokraitis avatar Jan 16 '19 20:01 abenokraitis

this PR should not be merged until https://github.com/ansible-network/config_manager/pull/19 is resolved and merged

privateip avatar Jan 16 '19 20:01 privateip