RHEL8-STIG icon indicating copy to clipboard operation
RHEL8-STIG copied to clipboard

(#126) RHEL-08-010141 Revision of Application Method: Templating

Open Rwarcards762 opened this issue 2 years ago • 1 comments

Overall Review of Changes:

Fixes problem discussed in #126 with proposed template solution -- no longer writes directly over grub.cfg which would get overwritten.

May be some variables this deprecates, etc. -- didn't dig into that.

Issue Fixes:

#126

How has this been tested?:

Tested in own environment to ensure functionality -- figured I would open it here as a PR to get it rolling

Rwarcards762 avatar Oct 13 '22 15:10 Rwarcards762

In regards to test failures -- it must be pulling the relative path differently, as I definitely have no errors about the path for the template in my copy when run.

Rwarcards762 avatar Oct 13 '22 15:10 Rwarcards762

hi @Rwarcards762

Thanks again for all your work on this and other issues. For PRs we do require GPG and signed-off-by to be added to each commit. I have added this fixed into the Oct_updates branch.

uk-bolly

uk-bolly avatar Oct 26 '22 15:10 uk-bolly

Closing, as this is handled via the now-merged #136

Rwarcards762 avatar Oct 26 '22 17:10 Rwarcards762