molecule-podman icon indicating copy to clipboard operation
molecule-podman copied to clipboard

molecule-podman does not honor pull parameter

Open wouterhummelink opened this issue 4 years ago • 2 comments

On the docker driver it's supported to specify if the base image should be pulled or not. The podman driver does not, causing image updates in our pipeline not to occur.

wouterhummelink avatar Jan 29 '21 13:01 wouterhummelink

I think this could be fixed by adding a line like the following in the block at https://github.com/ansible-community/molecule-podman/blob/master/lib/molecule_podman/playbooks/create.yml#L89-L109 :

{% if item.pull is defined and item.pull %}--pull always{% elif item.pull is defined and not item.pull %}--pull never{% endif %}

@ssbarnea what do you think?

javierpena avatar Jan 29 '21 14:01 javierpena

Probably, make a PR. Sadly I am overloaded now so I cannot dig myself it but I can review a patch and tag a release if needed.

ssbarnea avatar Jan 29 '21 14:01 ssbarnea