ansible-community
fix #239 , use python-style templating instead of Jinja in the plugins login_cmd_template
This file assumes Jinja templating for the port parameter and passes a Jinja-style "{{ port }}".
https://github.com/ansible/molecule/blob/main/src/molecule/command/login.py#L105
When it reaches molecule, it is subsituted in this file and is done by python calling .format() on the string. That causes it to not render correctly and gives users issues running molecule login.
ref: https://github.com/ansible-community/molecule-plugins/issues/239
Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found:
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I tested by editing this change into my venv locally and can now log in correctly to ec2 instances by calling molecule login
Any news on this PR?
This bug breaks some of the plugin functionality quite badly.
@danielpodwysocki Please add a label to the PR. Would recommend to use 'patch' here. Otherwise following check is failing to success 'ack / ack / ack (pull_request_target) '. I think, after adding this label, the process of merging will be a step nearer.
@danielpodwysocki Please add a label to the PR. Would recommend to use 'patch' here. Otherwise following check is failing to success 'ack / ack / ack (pull_request_target) '. I think, after adding this label, the process of merging will be a step nearer.
@ekin-oener-provsn I miss permissions to do that here, I could only create the PR but seems I cannot edit labels. It will need to be someone with enough access to this repo.
Bump... the fix seems good, we just need a maintainer to add the label to the PR as the submitter asserts they lack permission to edit the labels.
Can confirm the PR fixed the issue locally for me, is it possible for it to be merged?
please please please get this merged, as we are re-writing all our ansible roles and this would help so much
please please please get this merged, as we are re-writing all our ansible roles and this would help so much
+1 please approve this.
@apatard Have had a quick look at the failed builds and can see that centos:7 is failing, as thats now EOL should that be removed?
@apatard Have had a quick look at the failed builds and can see that
centos:7is failing, as thats now EOL should that be removed?
I found time to fix that the other day but didn't find enough time to clean, push and create a PR. I hope I'll do it this week
PR opened, and looks like the CI is green, so only a reviewer is needed to get it merged. This should unblock this PR
Any news here?
This is a rather annoying bug to work around and feels like something we should be addressing in weeks, not months?
Any news here?
This is a rather annoying bug to work around and feels like something we should be addressing in weeks, not months?
once the CI is fixed, this PR will be merged. As long as my PR about fixing the CI is not merged (in this form or any other form), I fear it's stuck :(
Right, looks like my PR has been merged (big thanks to @ssbarnea). Once this PR is rebased, it'll be ready to be merged I guess.
Right, looks like my PR has been merged (big thanks to @ssbarnea). Once this PR is rebased, it'll be ready to be merged I guess.
Awesome - I've rebased off of main.
