ara
ara copied to clipboard
ansible-community
WIP: Host index improvements
Improvements on host index site. Background: #331
- filter possibility for playbook name and path
- playbook name column in table
Build failed.
:heavy_check_mark: ara-tox-py3 SUCCESS in 3m 33s :heavy_check_mark: ara-tox-linters SUCCESS in 3m 31s :heavy_check_mark: ara-basic-ansible-core-devel SUCCESS in 4m 44s (non-voting) :heavy_check_mark: ara-basic-ansible-6 SUCCESS in 5m 04s :heavy_check_mark: ara-basic-ansible-core-2.13 SUCCESS in 6m 06s :heavy_check_mark: ara-basic-ansible-core-2.12 SUCCESS in 5m 38s :heavy_check_mark: ara-basic-ansible-core-2.11 SUCCESS in 5m 51s :heavy_check_mark: ara-basic-ansible-2.9 SUCCESS in 4m 40s :x: ara-container-images FAILURE in 5m 09s
![softwarefactory-project-zuul[bot] avatar](https://avatars.githubusercontent.com/in/6924?v=4 "Published by a pub.dev verified publisher"){kind=small}
Build failed.
:heavy_check_mark: ara-tox-py3 SUCCESS in 4m 02s :heavy_check_mark: ara-tox-linters SUCCESS in 3m 56s :heavy_check_mark: ara-basic-ansible-core-devel SUCCESS in 6m 44s (non-voting) :heavy_check_mark: ara-basic-ansible-6 SUCCESS in 4m 54s :heavy_check_mark: ara-basic-ansible-core-2.13 SUCCESS in 5m 06s :heavy_check_mark: ara-basic-ansible-core-2.12 SUCCESS in 5m 23s :heavy_check_mark: ara-basic-ansible-core-2.11 SUCCESS in 5m 19s :heavy_check_mark: ara-basic-ansible-2.9 SUCCESS in 4m 59s :x: ara-container-images FAILURE in 5m 20s
@hille721 looks good to me at a first glance -- I'm still trying to fix the unrelated CI issue with the container images.
@hille721 looks good to me at a first glance -- I'm still trying to fix the unrelated CI issue with the container images.
@dmsimard : in #331 you had a proposal to drop the task icons with zero. I would include this in this PR as well. If you push this to your branch I can rebase this one
@hille721 looks good to me at a first glance -- I'm still trying to fix the unrelated CI issue with the container images.
@dmsimard : in #331 you had a proposal to drop the task icons with zero. I would include this in this PR as well. If you push this to your branch I can rebase this one
oof, I don't think I committed that to a branch but I'm sure I could come up with something. Hang on.
@hille721 https://github.com/dmsimard/ara/commit/17ad2ee3621efbe42b120ae51b2f8c40ef5ba86c works for me, I don't think we need something more than that.
Build succeeded.
:heavy_check_mark: ara-tox-py3 SUCCESS in 4m 21s :heavy_check_mark: ara-tox-linters SUCCESS in 4m 22s :heavy_check_mark: ara-basic-ansible-core-devel SUCCESS in 10m 49s (non-voting) :heavy_check_mark: ara-basic-ansible-6 SUCCESS in 4m 57s :heavy_check_mark: ara-basic-ansible-core-2.13 SUCCESS in 11m 10s :heavy_check_mark: ara-basic-ansible-core-2.12 SUCCESS in 10m 34s :heavy_check_mark: ara-basic-ansible-core-2.11 SUCCESS in 5m 51s :heavy_check_mark: ara-basic-ansible-2.9 SUCCESS in 7m 44s :heavy_check_mark: ara-container-images SUCCESS in 12m 32s
Tested it and it looks good!
I've added two suggestions to include &latest=false for the playbook name and path because I think the intent would be to return every host result for that playbook, not just the latest one.
What do you think ?
Other than that it's ready to land IMO.
mmh good question. I think it can also make sense to get only latest hosts. E.g. to see the last results of a specific playbook.
But we could make it dependend if Include all playbook reports is set or not. What do you thing about that?
Edit: with 459b525 I added &latest={{ request.GET.latest | default:'true' }} to the link to take into account if Include all playbook reports was set or not.
Does this make sense to you?
Build succeeded.
:heavy_check_mark: ara-tox-py3 SUCCESS in 4m 06s :heavy_check_mark: ara-tox-linters SUCCESS in 4m 40s :heavy_check_mark: ara-basic-ansible-core-devel SUCCESS in 5m 53s (non-voting) :heavy_check_mark: ara-basic-ansible-6 SUCCESS in 5m 39s :heavy_check_mark: ara-basic-ansible-core-2.13 SUCCESS in 5m 53s :heavy_check_mark: ara-basic-ansible-core-2.12 SUCCESS in 5m 27s :heavy_check_mark: ara-basic-ansible-core-2.11 SUCCESS in 5m 40s :heavy_check_mark: ara-basic-ansible-2.9 SUCCESS in 6m 08s :heavy_check_mark: ara-container-images SUCCESS in 11m 18s
mmh good question. I think it can also make sense to get only latest hosts. E.g. to see the last results of a specific playbook.
But we could make it dependend if Include all playbook reports is set or not. What do you thing about that?
Edit: with 459b525 I added
&latest={{ request.GET.latest | default:'true' }}to the link to take into account if Include all playbook reports was set or not. Does this make sense to you?
That makes sense.
Looks good to me, this is a good improvement on the hosts page. Thanks @hille721 :)