ara icon indicating copy to clipboard operation
ara copied to clipboard

playbook name sometimes not recorded

Open hille721 opened this issue 4 years ago • 3 comments

What is the issue ?

From time to time it happens that a playbook name will not be recored: image

I checked the database, the name is null there.

I can't see any patterns, errors or reason why this happens.

What should be happening ?

If ara_playbook_name: is set, the playbook name should always recorded correctly.

hille721 avatar Sep 23 '21 16:09 hille721

Thanks for the issue @hille721 !

Knowing that the name is not set in the database already excludes the possibility that it's a frontend bug so that is good to know.

If the name doesn't make it to the database, it probably has to do with the callback then. There should only be two places to look at:

  • https://github.com/ansible-community/ara/blob/8f979b3ab2014959dda537e8351135515253a4d1/ara/plugins/callback/ara_default.py#L312-L315
  • https://github.com/ansible-community/ara/blob/8f979b3ab2014959dda537e8351135515253a4d1/ara/plugins/callback/ara_default.py#L461-L463

Maybe we can add some debug logging in there to find out what's happening. Since it is running in a thread, it would be interesting to know if we are able to reproduce with 1 thread (which is the default) and with ARA_CALLBACK_THREADS=4 (the max).

dmsimard avatar Sep 23 '21 17:09 dmsimard

can't reproduce the issue with only 1 thread, thus seems to be a mutlipe thread (=4) issue

hille721 avatar Sep 23 '21 17:09 hille721

@hille721 @dmsimard I didn't change any thread value, so I guess it was 1 thread by default, but I saw the same issue again.

saranyasridharan avatar Sep 24 '21 14:09 saranyasridharan