ara icon indicating copy to clipboard operation
ara copied to clipboard

Ignore Dry-Runs (--check)

Open rntbrgtt opened this issue 5 years ago • 4 comments

What component is this about ?

I would like to be able to ignore all Dry-Runs (--check) and not save those executions on ARA database.

What is your ARA installation like ?

ARA 1.4.2 Installed from pip Virtual Env Debian GNU/Linux 10 (buster) Mysql Database

What is the idea ?

The idea is to just have the important playbook executions on ARA database.

rntbrgtt avatar Jul 07 '20 07:07 rntbrgtt

Hey @rntbrgtt and thanks for the issue !

I think we can do that. It would be a setting for the callback and if it determines that --check is enabled, it wouldn't do anything.

I actually have a similar need that I planned on working on soon and while it isn't exactly what you've asked for, how would you feel if dry-run playbooks could be easily identified or filtered ?

I don't know exactly what shape or form this would take yet. We currently know if a playbook ran in "--check" through the CLI arguments: Screenshot from 2020-07-07 09-55-29

We could use the value of <playbook>["arguments"]["check"] and then do something with that, whether it's to highlight in a different color, filtering in (or out), etc.

dmsimard avatar Jul 07 '20 14:07 dmsimard

Hi dmsimard ,

Thanks for your help and time working on this.

We always run dry runs with --check or -C so if you use that to identify it will work for us.

Regards,

rntbrgtt avatar Jul 07 '20 14:07 rntbrgtt

Hey @rntbrgtt, I haven't had time for this yet but I'd like to include something for this in v1.5.

dmsimard avatar Jul 18 '20 18:07 dmsimard

I'm going to test an approach to use labels to highlight check mode, it's WIP here: https://review.opendev.org/#/c/752259/

dmsimard avatar Sep 16 '20 15:09 dmsimard