ara-collection icon indicating copy to clipboard operation
ara-collection copied to clipboard

Debian 12 support

Open borgwaldtk opened this issue 1 year ago • 9 comments

  • support using system packages in installation venv
  • changed version pinning of psycopg2 to reflect the comment
  • updated package dependencies for Debian 12

Tested with pypi installation method, postgresql backend using Debian's package python3-psycopg2 (version 2.9.5-1+b1).

borgwaldtk avatar Jul 11 '23 07:07 borgwaldtk

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/79c7449a4f4f4c2499b87c18412ae3f6

:heavy_check_mark: ara-role-api-distributed-sqlite SUCCESS in 13m 09s :heavy_check_mark: ara-role-api-mysql SUCCESS in 14m 19s :heavy_check_mark: ara-role-api-postgresql SUCCESS in 14m 25s :heavy_check_mark: ara-role-api-gunicorn-nginx SUCCESS in 12m 07s :heavy_check_mark: ara-role-api-gunicorn-nginx-client-cert SUCCESS in 11m 04s :x: ara-role-api-fedora-packages FAILURE in 6m 16s (non-voting)

Looks good, the whole "Debian 12, Python 3.11, thou shalt not install pip packages outside of pipx" prompted me to make #69, but good to see there's options now ;-)

@dmsimard maybe drop testing for Ubuntu and switch to Debian instead? I have my environment running on it, but it seems more people do :-)

Thulium-Drake avatar Jul 17 '23 08:07 Thulium-Drake

Using a venv still seems to be a valid way for Debian 12. But I did not see a real advantage in using pipx instead of pip, so I tried not to make too many changes.

ghost avatar Jul 17 '23 14:07 ghost

Hello, sorry for the delay and thanks for the PR!

I've actually just recently used the collection to deploy on top of Debian 12, I had filed these issues but you beat me to sending a PR:

  • https://github.com/ansible-community/ara-collection/issues/66
  • https://github.com/ansible-community/ara-collection/issues/67

This looks good at first glance but I will review it sometime soon.

dmsimard avatar Jul 18 '23 02:07 dmsimard

@dmsimard maybe drop testing for Ubuntu and switch to Debian instead? I have my environment running on it, but it seems more people do :-)

At this time this is dependant on Debian being available in Zuul (which it isn't). That's not to say we couldn't do it via a github action or something like that but it's probably a bigger discussion to have.

dmsimard avatar Jul 18 '23 02:07 dmsimard

Any updates on this?

xorwow avatar Jan 31 '24 13:01 xorwow

Hi @xorwow, I would like to merge this into an upcoming release in the not-too-distant future.

There is some maintenance and bug fixes to make CI happy (for example here) and we will eventually get to this PR.

I would also like to address our lack of CI coverage on Debian to make sure it is tested.

dmsimard avatar Feb 11 '24 01:02 dmsimard

I will have an opportunity to test this soon, it will be included in an upcoming bugfix release.

dmsimard avatar Apr 19 '24 23:04 dmsimard

The opportunity is here and I am working my way through this. Sorry it's taken so long.

For context I will be migrating the existing live demo (https://demo.recordsansible.org/) to Debian 12 and it is already set up to use the collection with https://github.com/ansible-community/ara-infra/blob/master/playbooks/live-demo.yaml.

It's historically been deployed to CentOS but I'll use the collection to redeploy it.

dmsimard avatar May 19 '24 05:05 dmsimard