antsibull icon indicating copy to clipboard operation
antsibull copied to clipboard

Stop calling distribution packages sdists?

Open webknjaz opened this issue 1 year ago • 2 comments

I noticed that antsibull-build rebuild-single accepts --sdist-dir which is technically a lie. It calls python -m build internally that produces both an sdist and a wheel.

The helper function is kinda called correctly: https://github.com/ansible-community/antsibull/blob/f6fda44642e8c1d7f346cde2715dc62a824681ae/src/antsibull/build_ansible_commands.py#L316 — make_dist_with_wheels(). "Kinda" because wheels are dists, it's like daying "dist with dists". And it's called with an "sdist dir" at https://github.com/ansible-community/antsibull/blob/f6fda44642e8c1d7f346cde2715dc62a824681ae/src/antsibull/build_ansible_commands.py#L742C9-L742C71.

This confusion leaked into the CLI/UX and external descriptions, including GHA workflows with steps like "Upload Ansible sdist to PyPI” being inspired by the misconception that it doesn't upload wheels.

Hence $sbj.

webknjaz avatar Jul 12 '23 17:07 webknjaz