vyos.vyos icon indicating copy to clipboard operation
vyos.vyos copied to clipboard

Impove support for 1.4 Firewall Rules Syntax

Open sdwilsh opened this issue 5 months ago • 3 comments

Change Summary

A big changed happened in 1.4-rolling-202308040557, and this collection currently cannot handle the syntax after that. That means one cannot use current rolling releases and expect firewall rules setting to work.

I am certain this is not exhaustive, but it is a big improvement in what actually works!

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes)
  • [ ] Other (please describe):

Related Task(s)

https://vyos.dev/T6706

Related PR(s)

Proposed changes

This is a non-breaking change for anything that isn't newer than 1.4-rolling-202308040557.

How to test

The regular expression used in this change was tested at https://regex101.com/r/gDIVEI/1

Checklist:

  • [x] I have read the CONTRIBUTING document
  • [x] I have linked this PR to one or more Phabricator Task(s)
  • [x] My commit headlines contain a valid Task id

sdwilsh avatar Sep 09 '24 05:09 sdwilsh