kubernetes.core icon indicating copy to clipboard operation
kubernetes.core copied to clipboard

Published 20 hours ago • verified publisher icon ansible-collections

Revert "Remove kubeconfig value from module invocation log (#826)"

Open jmighion opened this issue 8 months ago • 10 comments

This reverts commit 6efabd3418cbee9b96430d8374bf16738e48b04e.

SUMMARY

Fixes #870 A better solution is necessary to address #782. The current code makes getting manifests practically unusable. We need to revert this commit until a better solution is found.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

kubeconfig

jmighion avatar Apr 10 '25 16:04 jmighion

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/3af9e1bfaa564fa8a4470b05f2111f8b

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 17s :heavy_check_mark: build-ansible-collection SUCCESS in 5m 33s

softwarefactory-project-zuul[bot] avatar Apr 10 '25 16:04 softwarefactory-project-zuul[bot]

@jmighion, please add a changelog fragment

yurnov avatar Apr 11 '25 04:04 yurnov

@yurnov done!

jmighion avatar Apr 11 '25 16:04 jmighion

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/20b513bbffca48cf9fb431b9a9f3ddaf

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 22s :heavy_check_mark: build-ansible-collection SUCCESS in 5m 32s

softwarefactory-project-zuul[bot] avatar Apr 11 '25 16:04 softwarefactory-project-zuul[bot]

can anyone please approve this?

shaleenbathla avatar May 07 '25 05:05 shaleenbathla

+1 for approval — we're currently blocked from upgrading past kubernetes.core 5.0.0 due to this issue.

pedro-peter avatar May 07 '25 14:05 pedro-peter

@yurnov please approve this revert for next version

shaleenbathla avatar May 20 '25 08:05 shaleenbathla

@yurnov please approve this revert for next version

I'm not maintainer of this repo

yurnov avatar May 20 '25 08:05 yurnov

@beeankha ?

shaleenbathla avatar May 20 '25 08:05 shaleenbathla

+1 for revert, this is blocking anyone using ansible with a kube_config provided at runtime...

loicortola avatar Jun 11 '25 12:06 loicortola

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/c0a71a65a20f45429380ffbc9ecd8e5c

:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 21s :heavy_check_mark: build-ansible-collection SUCCESS in 6m 38s

softwarefactory-project-zuul[bot] avatar Jul 22 '25 16:07 softwarefactory-project-zuul[bot]

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/1705ced1b5e7b2374877d2a5f9d7c400b59ca2b0/pr-899

Backported as https://github.com/ansible-collections/kubernetes.core/pull/965

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar Jul 22 '25 16:07 patchback[bot]

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/1705ced1b5e7b2374877d2a5f9d7c400b59ca2b0/pr-899

Backported as https://github.com/ansible-collections/kubernetes.core/pull/966

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] avatar Jul 22 '25 16:07 patchback[bot]