ibm_zos_core icon indicating copy to clipboard operation
ibm_zos_core copied to clipboard

Enabler/1319/redesign mvs raw

Open AndreMarcel99 opened this issue 10 months ago • 2 comments

SUMMARY

Wrapper classes with the arguments not used are now included, delete parameters unnecessary types for arguments and logic of assign values as also the output.

Fixes #1358 #1319 and #1359

ISSUE TYPE
  • Bugfix Pull Request
  • Enabler Pull Request
COMPONENT NAME

Keys as a value to get the dd_type avoiding consult the name many times and types of arguments not used.

ADDITIONAL INFORMATION

The design of module work correctly now includes all parameters in arguments to be for the classes, to ensure a new property of dd's response required a braking change in arguments acceptance.

Captura de pantalla 2024-04-29 a la(s) 1 58 20 p m Captura de pantalla 2024-04-29 a la(s) 1 58 58 p m Captura de pantalla 2024-04-29 a la(s) 2 13 09 p m Captura de pantalla 2024-04-29 a la(s) 2 13 17 p m

Outputs of playbooks with verbose true for cases 1358 and 1359


PLAY [zvm] *********************************************************************************************************************************************************************************************

TASK [create data set to LISTCAT] **********************************************************************************************************************************************************************
changed: [zvm]

TASK [mvs raw with verbose with rc=0] ******************************************************************************************************************************************************************
changed: [zvm]

TASK [print output] ************************************************************************************************************************************************************************************
ok: [zvm] => {
    "msg": [
        {
            "backups": [],
            "changed": true,
            "dd_names": [
                {
                    "byte_count": 1205,
                    "content": [
                        "\fIDCAMS  SYSTEM SERVICES                                           TIME: 12:30:20        04/29/24     PAGE      1",
                        "",
                        "        ",
                        " LISTCAT ENTRIES('USER.WHAT.EVER')",
                        "",
                        "NONVSAM ------- USER.WHAT.EVER",
                        "     IN-CAT --- SYS1.ECTEST.MASTER.CATALOG\fIDCAMS  SYSTEM SERVICES                                           TIME: 12:30:20        04/29/24     PAGE      2",
                        "",
                        "         THE NUMBER OF ENTRIES PROCESSED WAS:",
                        "                   AIX -------------------0",
                        "                   ALIAS -----------------0",
                        "                   CLUSTER ---------------0",
                        "                   DATA ------------------0",
                        "                   GDG -------------------0",
                        "                   INDEX -----------------0",
                        "                   NONVSAM ---------------1",
                        "                   PAGESPACE -------------0",
                        "                   PATH ------------------0",
                        "                   SPACE -----------------0",
                        "                   USERCATALOG -----------0",
                        "                   TAPELIBRARY -----------0",
                        "                   TAPEVOLUME ------------0",
                        "                   TOTAL -----------------1",
                        "",
                        "         THE NUMBER OF PROTECTED ENTRIES SUPPRESSED WAS 0",
                        "",
                        "IDC0001I FUNCTION COMPLETED, HIGHEST CONDITION CODE WAS 0",
                        "",
                        "        ",
                        "",
                        "IDC0002I IDCAMS PROCESSING COMPLETE. MAXIMUM CONDITION CODE WAS 0",
                        ""
                    ],
                    "dd_name": "SYSPRINT",
                    "name": "USER.WHAT.EVER.ONE",
                    "record_count": 32
                }
            ],
            "failed": false,
            "ret_code": {
                "code": 0
            },
            "stdout": "",
            "stdout_lines": []
        }
    ]
}

TASK [mvs raw with verbose with rc=0] ******************************************************************************************************************************************************************
changed: [zvm]

TASK [print output] ************************************************************************************************************************************************************************************
ok: [zvm] => {
    "msg": [
        {
            "backups": [],
            "changed": true,
            "dd_names": [
                {
                    "byte_count": 1205,
                    "content": [
                        "\fIDCAMS  SYSTEM SERVICES                                           TIME: 12:30:32        04/29/24     PAGE      1",
                        "",
                        "        ",
                        " LISTCAT ENTRIES('USER.WHAT.EVER')",
                        "",
                        "NONVSAM ------- USER.WHAT.EVER",
                        "     IN-CAT --- SYS1.ECTEST.MASTER.CATALOG\fIDCAMS  SYSTEM SERVICES                                           TIME: 12:30:32        04/29/24     PAGE      2",
                        "",
                        "         THE NUMBER OF ENTRIES PROCESSED WAS:",
                        "                   AIX -------------------0",
                        "                   ALIAS -----------------0",
                        "                   CLUSTER ---------------0",
                        "                   DATA ------------------0",
                        "                   GDG -------------------0",
                        "                   INDEX -----------------0",
                        "                   NONVSAM ---------------1",
                        "                   PAGESPACE -------------0",
                        "                   PATH ------------------0",
                        "                   SPACE -----------------0",
                        "                   USERCATALOG -----------0",
                        "                   TAPELIBRARY -----------0",
                        "                   TAPEVOLUME ------------0",
                        "                   TOTAL -----------------1",
                        "",
                        "         THE NUMBER OF PROTECTED ENTRIES SUPPRESSED WAS 0",
                        "",
                        "IDC0001I FUNCTION COMPLETED, HIGHEST CONDITION CODE WAS 0",
                        "",
                        "        ",
                        "",
                        "IDC0002I IDCAMS PROCESSING COMPLETE. MAXIMUM CONDITION CODE WAS 0",
                        ""
                    ],
                    "dd_name": "SYSPRINT",
                    "name": "USER.WHAT.EVER.ONE",
                    "record_count": 32
                }
            ],
            "failed": false,
            "ret_code": {
                "code": 0
            },
            "stdout": "",
            "stdout_lines": []
        }
    ]
}

TASK [delete data sets] ********************************************************************************************************************************************************************************
changed: [zvm] => (item=USER.WHAT.EVER)
changed: [zvm] => (item=USER.WHAT.EVER.ONE)

PLAY RECAP *********************************************************************************************************************************************************************************************
zvm                        : ok=6    changed=4    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0  

Playbook:

  vars:
    ZOAU: "/zoau/v1.3.0"
    PYZ: "/allpython/3.11/usr/lpp/IBM/cyp/v3r11/pyz"
    RC_0_DATA_SET_NAME: "USER.WHAT.EVER.ONE"
    DATA_SET_TO_LISTCAT: "USER.WHAT.EVER"
    IDCAMS_STDIN: " LISTCAT ENTRIES('{{ DATA_SET_TO_LISTCAT | upper }}')"
  tasks:

    - name: create some data set
      block:
        - name: create data set to LISTCAT
          zos_data_set:
            name: "{{ DATA_SET_TO_LISTCAT }}"
            type: seq
            state: present
            replace: yes

        - name: mvs raw with verbose with rc=0
          zos_mvs_raw:
            verbose: True
            program_name: idcams
            auth: True
            dds:
              - dd_data_set:
                  dd_name: SYSPRINT
                  data_set_name: "{{ RC_0_DATA_SET_NAME }}"
                  disposition: new
                  type: seq
                  return_content:
                    type: text
              - dd_input:
                  dd_name: SYSIN
                  content: "{{ IDCAMS_STDIN }}"
          register: output_rc_0

        - name: print output
          debug:
            msg:
              - "{{ output_rc_0 }}"

        - name: mvs raw with verbose with rc=0
          zos_mvs_raw:
            verbose: False
            program_name: idcams
            auth: True
            dds:
              - dd_data_set:
                  dd_name: SYSPRINT
                  data_set_name: "{{ RC_0_DATA_SET_NAME }}"
                  disposition: old
                  type: seq
                  return_content:
                    type: text
              - dd_input:
                  dd_name: SYSIN
                  content: "{{ IDCAMS_STDIN }}"
          register: output_rc_0

        - name: print output
          debug:
            msg:
              - "{{ output_rc_0 }}"

      always:
        - name: delete data sets
          zos_data_set:
            name: "{{ item }}"
            state: absent
          loop:
            - "{{ DATA_SET_TO_LISTCAT }}"
            - "{{ RC_0_DATA_SET_NAME }}"

AndreMarcel99 avatar Apr 23 '24 16:04 AndreMarcel99

Captura de pantalla 2024-05-03 a la(s) 9 09 35 a m Fail because haven't merge dev at the moment I tested

AndreMarcel99 avatar May 03 '24 15:05 AndreMarcel99

Selected changes requested to get my questions answered before merging, but no changes were asked for.

fernandofloresg avatar May 03 '24 15:05 fernandofloresg