ansible-collections
Adding support for Google Secret Manager for issue 543
SUMMARY
Add support for Google Secret Manager as both a module and lookup plugin. Fixes #543
ISSUE TYPE
- Feature Pull Request
COMPONENT NAME
gcp_secret_manager
ADDITIONAL INFORMATION
Basic support for GCP secret manager with some testing
Thank you so much for reviewing this and trying the merge. You caught me at like the worst time on this, but I'm getting back to resolving the issues you brought up and the lint issues with the merge today/tomorrow.
Cheers, I'll make an updated commit soon.
Thank you so much for reviewing this and trying the merge. You caught me at like the worst time on this, but I'm getting back to resolving the issues you brought up and the lint issues with the merge today/tomorrow.
Cheers, I'll make an updated commit soon.
sounds great! and no worries - apologies about my belated review here.
Just ping me when you're ready again - I'm trying to be a little more reactive to PR reviews.
@toumorokoshi Just checking in on this. I'm sure you have a million things to do, but just wanted to check with you to see if this was still something that could potentially be merged. Thank you for your time on this.
Hey just checking back on this. Again, I'm sure you're very busy. I also have no idea what your release plans are for this. Curious if this will be merged?
Hi! Unfortunately I've left Google and am no longer the official repository maintainer.
That said: it looks like I still have permissions to merge. @SirGitsalot are you able to take a look? or do you want me to see if I can review and get this in?
it's a real bummer that this got missed for another release. Shoudl we just close this issue if it won't be worked on?
I'll ping @SirGitsalot again - as much as I'd like to help merge this in since I'm not an employee I think it's best if we leave it to the official maintainer.
Thanks @toumorokoshi, for helping even though you've moved on. Can you assign @SirGitsalot to be the reviewer of this instead of you?
Thanks @toumorokoshi, for helping even though you've moved on. Can you assign @SirGitsalot to be the reviewer of this instead of you?
done!
@SirGitsalot Hi guys! Why hasn't this been merged yet? It was created almost a year ago. I need this feature.
I'm not sure if this will ever be merged. I'm the author, I know there's feedback on this, but I'm not open to making more changes to something that will never be merged. Not sure what Google's strategy on this collection is any longer. Feel free to try to manually merge my fork into a collection if you really need it.
Hi, @SirGitsalot will that Secret manager going to be put into a release anytime soon by any chance? Our team would love to use it officially.
Hi @SirGitsalot, repeating the request from @martiniDB. Any timeline for this module to be released?
I haven't tried it out yet, but it looks like it got published in https://github.com/ansible-collections/google.cloud/releases/tag/v1.4.0 and docs are on Galaxy here! Thanks @SirGitsalot!
