google.cloud icon indicating copy to clipboard operation
google.cloud copied to clipboard

Published 20 hours ago • verified publisher icon ansible-collections

Add Service Account Impersonation + Secret Manager Filter

Open upodroid opened this issue 4 years ago • 5 comments

SUMMARY
  • Added Service Account Impersonation
  • Tweaked KMS Filter to default to ADC Auth.
  • Added Secret Manager Filter
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@rambleraptor ^

upodroid avatar Nov 02 '20 15:11 upodroid

The impersonation part would be very helpful for us. Any chance of getting it merged?

aoktox avatar Oct 05 '22 06:10 aoktox

cc @toumorokoshi

aoktox avatar Oct 05 '22 06:10 aoktox

@aoktox thanks for the ping! Hopefully we get all these cleaned up, but calling out the important ones is helpful for now.

I took a quick look but I'm worried we don't have enough testing to merge it in as-is. If you want to try updating it that would be great, otherwise it'll be in my queue along with the other 30 PRs, and likely an AI after I get all the tests passing in the CI.

toumorokoshi avatar Oct 08 '22 16:10 toumorokoshi

What's the deal with this one? This would be very useful for my team. SA impersonation is an widely used feature of GCP automation. Seems like ansible should be leveraging its use already.

DaveSchile-Zonar avatar Mar 21 '24 00:03 DaveSchile-Zonar

I've created a version of this with just the impersonation changes, plus documentation updates: https://github.com/ansible-collections/google.cloud/pull/627

ktchernov avatar May 05 '24 23:05 ktchernov