dellemc.enterprise_sonic icon indicating copy to clipboard operation
dellemc.enterprise_sonic copied to clipboard

Poe

Open xhan-dell opened this issue 1 year ago • 4 comments

SUMMARY

Implement Ansible resource module for Power over Ethernet in enterprise sonic. Includes

  • argspec
  • facts gathering
  • merged, deleted, replaced, and overridden states for setting configuration
  • handling diff and check modes
  • unit tests
  • regression tests
GitHub Issues

N/A

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sonic_poe

OUTPUT

poe_regression_output5-22-24.txt poe_regression_results_pdf5-22-24.pdf

ADDITIONAL INFORMATION

Platforms available for testing does not support all configurable attributes. error messages are too long to fit on the report. The first test case is supposed to work as it contains only attributes supported, but is failing due to a bug in internal sonic that has been reported. The rest contain configuration that is not supported by platform.

Checklist:
  • [x] I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • [x] I have verified that new and existing unit tests pass locally with my changes
  • [x] I have not allowed coverage numbers to degenerate
  • [X] I have maintained at least 90% code coverage
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • [ ] I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Added tests for merging all settings, deleting each element, and/or clearing lists, and overridding and replacing parts.

xhan-dell avatar Jan 17 '24 00:01 xhan-dell

I'm attempting to clear the failing "changelog" check for this PR (already labeled as a "new_resource_module") by closing and re-opening the PR.

kerry-meyer avatar Jan 18 '24 21:01 kerry-meyer

updated poe regression after feedback poe_regression_output5-16-24.txt.txt poe_regression_results_pdf5-16-24.pdf

xhan-dell avatar May 16 '24 21:05 xhan-dell

updated poe regression after using subset of settings that works on switch poe_regression_output5-22-24.txt poe_regression_results_pdf5-22-24.pdf

xhan-dell avatar May 24 '24 22:05 xhan-dell

poe_regression_output5-30-24.txt poe_regression_results_pdf5-30-24.pdf And check and diff modes enabled, didn't seem to get an results html file poe_regression_check_diff_output5-30-24.txt

xhan-dell avatar May 31 '24 03:05 xhan-dell