dellemc.enterprise_sonic icon indicating copy to clipboard operation
dellemc.enterprise_sonic copied to clipboard

Published 20 hours ago • verified publisher icon ansible-collections

Add Enterprise SONIC LLDP Interface module

Open m-nazeer opened this issue 1 year ago • 3 comments

SUMMARY

LLDP_INTERFACES Module implementation

GitHub Issues

N/A

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

sonic_lldp_interfaces

OUTPUT

Regression Test HTML report: lldp_interface_log.zip

Checklist:
  • [x] I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • [x] I have verified that new and existing unit tests pass locally with my changes
  • [x] I have not allowed coverage numbers to degenerate
  • [x] I have maintained at least 90% code coverage
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • [x] I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

m-nazeer avatar Oct 31 '23 15:10 m-nazeer

Closing and re-opening to clear "failure" for a missing fragment file.

kerry-meyer avatar Jan 25 '24 06:01 kerry-meyer

To proceed with the code review for this resource module, please push changes for the following items:

  • Re-sync your fork and branch to pull in updates from the "main" branch that are the probable cause of the flagged sanity failures for python3.10, 3.11, and 3.12 with the ansible-core "devel" version.
  • Add Unit Test coverage. Use the UT implementation for the DHCP Relay module as an example of how to do this.

While you are working on the UT changes, we may go ahead with checking the changes that are in the current change set and posting an initial set of comments/questions (if any) for the current code. The PR can not be approved or merged, however, until the items described above have been completed.

kerry-meyer avatar Jan 26 '24 08:01 kerry-meyer

to

Hi Kerry. I am working on addressing the review comments for overridden and replaced logic. I will push the code changes once done

m-nazeer avatar Apr 10 '24 14:04 m-nazeer