6.2 update

[pyrodie18]

SUMMARY

Updated roles to support Zabbix 6.2 referenece #761

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

Various Roles

ADDITIONAL INFORMATION

N/A

[pyrodie18]

@D3DeFi , @BGmot , @dj-wasabi, and anyone else. I can't figure out why this thing keeps failing the sanity checks. Mind taking a peak?

[pyrodie18]

Fixes #764 and #761

[D3DeFi]

@pyrodie18 I think there were new checks added to upstream sanity testing

I doesn't seem to be related to your PR and will fail everything I think

ERROR: Found 7 pylint issue(s) which need to be resolved:
ERROR: plugins/httpapi/jsonrpc.py:95:4: arguments-renamed: Parameter 'data' has been renamed to 'request_method' in overridden 'HttpApi.send_request' method
ERROR: plugins/module_utils/wrappers.py:31:123: used-before-assignment: Using variable 'ZBX_IMP_ERR' before assignment
ERROR: plugins/modules/zabbix_action.py:555:43: format-string-without-interpolation: Using formatting for a string that does not have any interpolated variables
ERROR: plugins/modules/zabbix_group.py:143:119: used-before-assignment: Using variable 'ZBX_IMP_ERR' before assignment
ERROR: plugins/modules/zabbix_map.py:764:117: used-before-assignment: Using variable 'PYDOT_IMP_ERR' before assignment
ERROR: plugins/modules/zabbix_map.py:766:117: used-before-assignment: Using variable 'WEBCOLORS_IMP_ERR' before assignment
ERROR: plugins/modules/zabbix_map.py:768:111: used-before-assignment: Using variable 'PIL_IMP_ERR' before assignment@

[D3DeFi]

please have a look at #775 , after merging, you can rebase this branch and tests should pass

[codecov[bot]]

Codecov Report

Merging #773 (7545fd0) into main (fc6031c) will decrease coverage by 0.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
- Coverage   77.67%   77.63%   -0.05%     
==========================================
  Files          29       29              
  Lines        3857     3859       +2     
  Branches     1043     1043              
==========================================
  Hits         2996     2996              
- Misses        542      543       +1     
- Partials      319      320       +1     

Impacted Files	Coverage Δ
.../community/zabbix/plugins/module_utils/_version.py	40.00% <0.00%> (-1.82%)	:arrow_down:
...s/community/zabbix/plugins/modules/zabbix_group.py	79.45% <0.00%> (+0.28%)	:arrow_up:
.../community/zabbix/plugins/module_utils/wrappers.py	73.07% <0.00%> (+0.52%)	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[pyrodie18]

Looks like that did the trick @D3DeFi ....thanks

[dj-wasabi]

Nice! 👍

[D3DeFi]

This looks like a merge to me rather than rebase. It should be fine in the end after it is merged, but is very confusing to review as it includes changes from the already merged PRs.

What I usually recommend is:

git remote add upstream <this repo>
git fetch -a upstream
git checkout main
git rebase upstream/main
git checkout <this branch>
git rebase main
git push origin main
git push origin <this branch>

[D3DeFi]

@BGmot @mu1f407 can you give this PR a review too? Once approved we can merge. Ignore include_pattern logic and changes to plugins/modules/* as those were already merged to main

[BGmot]

Do I understand it right - we test only the latest Zabbix version for each distro? For example - only 6.2 for Debian 11 despite we claim that we support Zabbix 6.2, 6.0, 5.0, 4.0 ?

[pyrodie18]

This looks like a merge to me rather than rebase. It should be fine in the end after it is merged, but is very confusing to review as it includes changes from the already merged PRs.

What I usually recommend is:

git remote add upstream <this repo>
git fetch -a upstream
git checkout main
git rebase upstream/main
git checkout <this branch>
git rebase main
git push origin main
git push origin <this branch>

I ran rebase but apparently screwed it up. Sorry about that

[pyrodie18]

Do I understand it right - we test only the latest Zabbix version for each distro? For example - only 6.2 for Debian 11 despite we claim that we support Zabbix 6.2, 6.0, 5.0, 4.0 ?

Currently yes, I mentioned this in #766 . One of the things I would like to do as part of 2.0 is update the matrix to include all versions on all OSs that we support. But we may want to start a separate discussion about that since it's going to increase the number of tests that we run.

[dj-wasabi]

But we may want to start a separate discussion about that since it's going to increase the number of tests that we run.

That is indeed why I always used to test latest. But mostly also as I think someone has to pay for all the tests that we do, don't wanted to do something that would increase the costs that much..

[D3DeFi]

But we may want to start a separate discussion about that since it's going to increase the number of tests that we run.

That is indeed why I always used to test latest. But mostly also as I think someone has to pay for all the tests that we do, don't wanted to do something that would increase the costs that much..

As an open source, I think we have some credits for Github Actions on the repo for free. I think its their free 2000CI/CD minutes or something

[pyrodie18]

But we may want to start a separate discussion about that since it's going to increase the number of tests that we run.

That is indeed why I always used to test latest. But mostly also as I think someone has to pay for all the tests that we do, don't wanted to do something that would increase the costs that much..

As an open source, I think we have some credits for Github Actions on the repo for free. I think its their free 2000CI/CD minutes or something

Created a dedicated topic for this on #777

[D3DeFi]

Thanks all for discussion and @pyrodie18 for the heavy lifting here! :)