community.zabbix icon indicating copy to clipboard operation
community.zabbix copied to clipboard

zabbix_screen: documentation issues

Open D3DeFi opened this issue 4 years ago • 1 comments

From @richlv on 15 Apr 2019

SUMMARY

See https://docs.ansible.com/ansible/latest/modules/zabbix_screen_module.html .

There seem to be a few issues here that would need help from somebody familiar with this module, otherwise I'd have submitted a pull request. Some of these might turn out to be bugs in the module itself, too (like the host_group issue below).

  • [ ] The tagline is "This module allows you to create, modify and delete Zabbix screens and associated graph data.". It is not clear what associated graph data is meant here, surely this module does not modify any Zabbix custom graphs?
  • [ ] Screen properties are largely undocumented, except for appearing in the examples.
  • [x] The documentation says "When creating or updating screen(s), screen_name, host_group are required.". Zabbix screens are not tied to hostgroups, why is hostgroup required here (and supported in the first place)? Reading through the examples again and again, is this perhaps related to only graphs being supported, and thus group name where the graphs will be looked up from? If so, what will happen when there will be multiple graphs with the same name in the group?
  • [ ] All the parameters and the scant documentation talk about graphs - are graphs the only screen element type that is supported?
  • [ ] There's some special undocumented logic, as indicated by the code comment "when there're only one host, only one row is not good".
ISSUE TYPE
  • Bug Report
COMPONENT NAME

zabbix_screen

ANSIBLE VERSION

latest

CONFIGURATION

Not relevant.

OS / ENVIRONMENT

Not relevant.

Copied from original issue: ansible/ansible#55345

D3DeFi avatar May 04 '20 14:05 D3DeFi

Based on my comment this module needs a major rework.

D3DeFi avatar May 04 '20 14:05 D3DeFi