Add switchIpAddress to vmware_dvswitch module

[lumarel]

SUMMARY

This change makes it possible to change the Switch IP address parameter for the NetFlow config of a distributed vSwitch:

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

vmware_dvswitch

ADDITIONAL INFORMATION

As this is a parameter which belongs to the NetFlow config, I added it under the conditional of the netFlow_collector_ip, if this unwanted I can of course pull it one layer out! I'm not used to contributing to Modules so far, so please just point out every issue or improvement if needed, I will fix it 👍🏻

Tested with a self-built EE via navigator so far. Thanks!

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/daab88d0058a431d8caf628e8f9c4f03

:heavy_check_mark: ansible-tox-linters SUCCESS in 9m 43s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 22s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 19m 06s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 19m 18s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 54m 18s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 50m 11s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 27s

[softwarefactory-project-zuul[bot]]

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/3709c148a9244996bd2c80d0dc665d4e

:heavy_check_mark: ansible-tox-linters SUCCESS in 10m 58s :heavy_check_mark: build-ansible-collection SUCCESS in 11m 40s :x: ansible-test-cloud-integration-vcenter7_only-stable216 FAILURE in 16m 25s :warning: ansible-test-cloud-integration-vcenter7_2esxi-stable216 CANCELED :warning: ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 CANCELED :warning: ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED :heavy_check_mark: ansible-galaxy-importer SUCCESS in 6m 03s

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/e8cf8da33df14e9f897cc94c4973b7eb

:heavy_check_mark: ansible-tox-linters SUCCESS in 10m 14s :heavy_check_mark: build-ansible-collection SUCCESS in 11m 09s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 23m 13s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 21m 36s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 55m 27s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 1h 03m 16s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 28s

[lumarel]

@mariolenz do I still have something to do to bring this forward? 🙂

[mariolenz]

@lumarel If the CI succeeds I'll merge.

FYI I'm planning to do a new release the next couple of days so you should see this soon on galaxy. Or in the community package, if you use this. (That's why I want to do a new release soon, to get it into Ansible 9.5.0 which is due next week AFAIK :wink:)

[lumarel]

Great thank you for taking the time! 🙂 We are building our EEs with Ansible Builder regularly, but nice to have for everyone that might wait on this in the RPMs.

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/d3cad4bc5e6b4b7aa451efc3d79734a0

:heavy_check_mark: ansible-tox-linters SUCCESS in 10m 18s :heavy_check_mark: build-ansible-collection SUCCESS in 11m 31s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 25m 59s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 24m 03s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 56m 39s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 1h 01m 21s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 14s

[softwarefactory-project-zuul[bot]]

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/07cd7ae68c9d45f3a2476cc293e37928

:heavy_check_mark: ansible-tox-linters SUCCESS in 9m 51s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 04s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 37s

[softwarefactory-project-zuul[bot]]

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/91fcfecdd96a4fcfbfd16d0babcdc7a0

:heavy_check_mark: ansible-tox-linters SUCCESS in 11m 38s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 42s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 19m 59s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 21m 42s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 55m 37s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 1h 01m 26s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 18s

[mariolenz]

recheck

[softwarefactory-project-zuul[bot]]

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/5bd2c50ae6924272bf373597300d45e5

:heavy_check_mark: ansible-tox-linters SUCCESS in 11m 34s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 40s :warning: ansible-test-cloud-integration-vcenter7_only-stable216 CANCELED :warning: ansible-test-cloud-integration-vcenter7_2esxi-stable216 CANCELED :x: ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 ERROR Failed to update project ansible/ansible in 12s :warning: ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED :warning: ansible-galaxy-importer CANCELED

[softwarefactory-project-zuul[bot]]

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/30abc428e5f8495587935d8d93c05c85

:heavy_check_mark: ansible-tox-linters SUCCESS in 11m 18s :heavy_check_mark: build-ansible-collection SUCCESS in 11m 25s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 24m 02s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 22m 32s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 55m 35s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 1h 01m 57s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 06s

[lumarel]

Apologies if I broke something with my Rebase yesterday 😕 Will just fully leave it to you the next time...

[mariolenz]

I'm not sure if you broke something, but the pipeline didn't merge the PR. It's also possible that there has been a temporary failure int it.

Well, if it still doesn't want to merge I'll just do it myself.

[lumarel]

Thank you for doing the extra work 👍🏻

[softwarefactory-project-zuul[bot]]

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/4a52ee6431f94457aad7fe664857a613

:heavy_check_mark: ansible-tox-linters SUCCESS in 10m 55s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 28s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 20s