community.vmware
community.vmware copied to clipboard
ansible-collections
Add mac address fix to vmware_guest.py
SUMMARY
This change seeks to fix a problem encountered when building multiple VM's from a template, using customisation to apply new IP details, where the mac addresses are not properly handled by the customiser script.
Original change from https://github.com/ansible/ansible/issues/64774#issuecomment-554390558
This looks to fix #1391
ISSUE TYPE
- Bugfix Pull Request
COMPONENT NAME
vmware_guest
ADDITIONAL INFORMATION
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/79cc2481a3ce4a1aa349270b4b8b07cc
:heavy_check_mark: ansible-tox-linters SUCCESS in 8m 32s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 34s :x: ansible-test-sanity-docker-devel FAILURE in 10m 30s (non-voting) :heavy_check_mark: ansible-test-sanity-docker-milestone SUCCESS in 9m 59s (non-voting) :heavy_check_mark: ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 33s :heavy_check_mark: ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 07s :heavy_check_mark: ansible-test-units-community-vmware-python38 SUCCESS in 5m 32s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable214 SUCCESS in 19m 08s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable214 SUCCESS in 17m 25s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 SUCCESS in 1h 01m 43s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 SUCCESS in 51m 43s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 49s
![softwarefactory-project-zuul[bot] avatar](https://avatars.githubusercontent.com/in/6924?v=4 "Published by a pub.dev verified publisher"){kind=small}
The ansible/gate check seems stuck with no way to get an explanation as to why it didn't complete. Is there a way to trigger a re-check to move this MR along?
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/087a1b5552204f21b34285fdd7fcf200
:heavy_check_mark: ansible-tox-linters SUCCESS in 9m 51s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 18s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 22m 17s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 20m 43s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 52m 02s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 59m 14s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 09s
This PR fixes a bug that is a blocker for anyone trying to use vmware_guest to clone a template with a NIC attached and manually set the MAC address.
It's a three line diff, and the CI gate seems to be stuck.
@mariolenz is it possible for you to take a look at this?
Sorry, I didn't find the time yet to have a look at this. And I'll be AFK for a couple of days, so please bare with me.
Anyway, we've changed the CI to test with ansible-core 2.17 recently (ansible/ansible-zuul-jobs#1875) and I would like to see if your PR still works with this. So I'll close it and re-open it in a couple of minutes. Just to make sure that the CI really runs with 2.17.
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/b0e1fbabcd2b4d8e9d0d53bd4b5140d7
:heavy_check_mark: ansible-tox-linters SUCCESS in 9m 28s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 38s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable217 SUCCESS in 17m 38s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable217 SUCCESS in 14m 52s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 SUCCESS in 46m 11s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 SUCCESS in 59m 39s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 20s