community.vmware icon indicating copy to clipboard operation
community.vmware copied to clipboard

added support for configuring heartbeat on datastores

Open willt opened this issue 2 years ago • 18 comments

SUMMARY

This adds support for configuring the datastores to heartbeat as well as setting the heartbeat datastore selection policy.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_cluster_ha

willt avatar Apr 07 '22 19:04 willt

Any thoughts why this test would fail but other succeed? prepare_vmware_tests/tasks/main.yml:17 Seems like this one isn't loading all the same infrastructure as the other ones. Namely the datastores are undefined.

willt avatar Apr 08 '22 14:04 willt

@willt We have a general problem in our CI at the moment. Some of the unit tests run into RETRY_LIMIT. We're working on this at the moment. When this is fixed, we'll have a look at why ansible-test-cloud-integration-vcenter7_only-python36-stable211 fails here. Please be patient.

mariolenz avatar Apr 08 '22 18:04 mariolenz

recheck

mariolenz avatar Apr 09 '22 14:04 mariolenz

Is there a way to trigger the build process again without another commit ?

willt avatar Apr 09 '22 14:04 willt

Is there a way to trigger the build process again without another commit ?

I'm not sure what you mean with build process, but you can trigger an new CI run by adding a comment with the word recheck.

mariolenz avatar Apr 09 '22 14:04 mariolenz

New CI run is what I meant. I'm still drinking my first cup of coffee :) Thanks!

willt avatar Apr 09 '22 15:04 willt

recheck

willt avatar Apr 11 '22 17:04 willt

recheck

willt avatar Apr 13 '22 17:04 willt

2022-04-13 17:33:12.325364 | controller | TASK [vmware_cluster_ha : Change Heartbeat Datastores] *************************
2022-04-13 17:33:12.325446 | controller | task path: /home/zuul/.ansible/collections/ansible_collections/community/vmware/tests/integration/targets/vmware_cluster_ha/tasks/main.yml:305
2022-04-13 17:33:12.358245 | controller | fatal: [testhost]: FAILED! => {
2022-04-13 17:33:12.358279 | controller |     "msg": "The task includes an option with an undefined variable. The error was: 'ro_datastore' is undefined\n\nThe error appears to be in '/home/zuul/.ansible/collections/ansible_collections/community/vmware/tests/integration/targets/vmware_cluster_ha/tasks/main.yml': line 305, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n  - name: Change Heartbeat Datastores\n    ^ here\n"
2022-04-13 17:33:12.358287 | controller | }

You need to start tests/integration/targets/vmware_cluster_ha/tasks/main.yml with this to be sure the datastores are mounted:

  - import_role:
      name: prepare_vmware_tests
    vars:
      setup_attach_host: true
      setup_datastore: true

goneri avatar Apr 14 '22 14:04 goneri

All tests pass in my lab. I'm not sure why it's failing in CI here.

willt avatar Apr 14 '22 19:04 willt

recheck

willt avatar Apr 20 '22 20:04 willt

There hasn't been any activity on this PR for quite some time, so I'll close it for now. Feel free to re-open it or open a new one if you think it's important.

mariolenz avatar Apr 24 '23 17:04 mariolenz