community.proxysql icon indicating copy to clipboard operation
community.proxysql copied to clipboard

[FEEL FREE TO FINISH] New module: proxysql_cluster

Open akimrx opened this issue 4 years ago • 8 comments

SUMMARY

IF ANYONE WANTS TO FINISH IT BECAUSE OF https://github.com/ansible-collections/community.proxysql/pull/26#discussion_r672211213, FEEL FREE TO DO IT!

Added new module proxysql_cluster, which implements server management in the ProxySQL cluster. Read more here.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

proxysql_cluster

ADDITIONAL INFORMATION

The linked module proxysql_manage_config has also been updated.

akimrx avatar May 09 '21 12:05 akimrx

Codecov Report

Attention: Patch coverage is 71.06918% with 46 lines in your changes missing coverage. Please review.

Project coverage is 70.12%. Comparing base (beb3841) to head (6dc9442). Report is 75 commits behind head on main.

Files Patch % Lines
plugins/modules/proxysql_cluster.py 71.06% 34 Missing and 12 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   70.02%   70.12%   +0.10%     
==========================================
  Files           8       10       +2     
  Lines         994     1329     +335     
  Branches      164      220      +56     
==========================================
+ Hits          696      932     +236     
- Misses        222      295      +73     
- Partials       76      102      +26     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '21 12:05 codecov[bot]

@akimrx thanks for the new module! Could you please revert renaming of the ignore.txt

Andersson007 avatar May 10 '21 08:05 Andersson007

Hi! Yep, a little later

akimrx avatar May 10 '21 08:05 akimrx

If a specialist reviews, tests, and provides feedback that the c.proxysql users will get what they expect, we could merge the module

@markuman if you could take a look, it would be really great

Andersson007 avatar Jul 20 '21 09:07 Andersson007

FYI: Whoever finishes this, i believe it would be fair if they put themselves in the authors: list

Andersson007 avatar Jul 26 '21 13:07 Andersson007

If a specialist reviews, tests, and provides feedback that the c.proxysql users will get what they expect, we could merge the module

@markuman if you could take a look, it would be really great

I can take over. But I'd like to address #60, #61 and #62 first and release 1.2.0
So this will land in 1.3.0 if no one else will do it before :)

markuman avatar Aug 09 '21 19:08 markuman

If a specialist reviews, tests, and provides feedback that the c.proxysql users will get what they expect, we could merge the module @markuman if you could take a look, it would be really great

I can take over. But I'd like to address #60, #61 and #62 first and release 1.2.0 So this will land in 1.3.0 if no one else will do it before :)

sounds very good to me

Andersson007 avatar Aug 10 '21 10:08 Andersson007

If a specialist reviews, tests, and provides feedback that the c.proxysql users will get what they expect, we could merge the module @markuman if you could take a look, it would be really great

I can take over. But I'd like to address #60, #61 and #62 first and release 1.2.0 So this will land in 1.3.0 if no one else will do it before :)

I will target #19 for the next release.
the benefits of using proxysql in cluster mode are - imo - marginal. Most of the benefits are already targeted by using an orchestration tool like ansible.
If someone has some time to complete this, feel free to adopt this pr.

markuman avatar Aug 19 '21 19:08 markuman